Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

belong support issue on cpp method define [final attempt] #115

Closed
Peter-Chou opened this issue Oct 23, 2023 · 3 comments
Closed

belong support issue on cpp method define [final attempt] #115

Peter-Chou opened this issue Oct 23, 2023 · 3 comments

Comments

@Peter-Chou
Copy link

Peter-Chou commented Oct 23, 2023 •
edited
Loading

嗯~~~好吧。上图header文件有点歧义 ，我更新下 ：

image

仔细看图的话会发现：header文件中和cpp文件中其实 class的method belong并没有显示出来。
和面包屑比较并非希望belong变成面包屑，只是想突出下问题。
I hope we are on the same page...

Originally posted by @Peter-Chou in #114 (comment)
@Peter-Chou Peter-Chou changed the title belong support issue on cpp function define [final attmpt] belong support issue on cpp function define [final attempt] Oct 23, 2023
@Peter-Chou Peter-Chou changed the title belong support issue on cpp function define [final attempt] belong support issue on cpp method define [final attempt] Oct 23, 2023
@manateelazycat
Copy link
Owner

给源文件吧， 我不承诺一定修复， 时间有限。

@Peter-Chou
Copy link
Author

Peter-Chou commented Oct 24, 2023 •
edited
Loading

仓库地址：https://github.com/Peter-Chou/transformer_cpp_tokenizers
麻烦大佬有空看下啦，结果如何不重要。佛家有云：无心而为。

manateelazycat added a commit that referenced this issue Oct 24, 2023
@manateelazycat
Fix issue #115, to support cpp class and function node.
b72962f
@manateelazycat
Copy link
Owner

b72962f

应该修复了， 不同语言定义class和function的名称不一样， 只能慢慢穷举了， 都能修复。

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@manateelazycat @Peter-Chou