Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for multiple key strokes combinations #125

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Add support for multiple key strokes combinations #125

wants to merge 2 commits into from

Conversation

mrmarktyy
Copy link

Add support for multiple key strokes combinations, for example,

key('ctrl+r+s', function(){ alert('stopped reload!'); });
key('ctrl+shift+r', function(){ alert('reload!'); });
key('command+alt+p', function(){ alert('pause!!'); });
key('command+shift+w+p', function(){ alert('do something!!'); });

@mrmarktyy
Copy link
Author

Hi, Please let me know if you have any suggestion before merging in. Thank you

@mrmarktyy
This is for when certain shortcut triggers a window blur action (eg, …
4c32117 
…command+shift+c, command+tab), then some keys state won't be released in as events are fired in other window objects. As a result, it causes bug in method when comparing registed shortcuts with key states in So just reset the in window event handle which is here.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@mrmarktyy