optimized code

lvxianchao · Apr 18, 2019 · 156795b · 156795b
1 parent ae7ffe3
commit 156795b
Show file tree

Hide file tree

Showing 3 changed files with 9 additions and 12 deletions.
diff --git a/src/js/app.js b/src/js/app.js
@@ -31,8 +31,6 @@ low(new ChromeStorage('TheFuckingGithub')).then(db => {
         Vue.use(VueClipboard);
         Vue.use(VueLazyload, {
             loading: chrome.extension.getURL('icons/loading.gif'),
-            dispatchEvent: true,
-            lazyComponent: true,
         });
 
         window.app = new Vue({

diff --git a/src/js/components/App.vue b/src/js/components/App.vue
@@ -34,9 +34,8 @@
         </el-header>
 
         <Search @filter="filter" :starredCount="starredCount"></Search>
-        <!--v-lazy-container="{selector: 'img'}"-->
-        <el-container class="content" v-lazy-container="{selector: 'img'}">
-            <el-aside class="aside" style="width: 400px;">
+        <el-container class="content">
+            <el-aside class="aside" style="width: 400px;" v-lazy-container="{selector: 'img'}">
                 <div class="aside-scroll">
                     <el-badge :value="this.repositories.length" type="primary" class="repositories-count"/>
                     <el-card class="aside-card">
@@ -48,9 +47,9 @@
                                          @click.native="showRepository(repository, index)"
                                          shadow="hover">
                                     <div class="owner-avatar">
-                                        <img :src="loadingImgSrc" :data-src="repository.repo.owner.avatar_url"
-                                             :alt="repository.repo.owner.login"
-                                             :key="repository.repo.owner.avatar_url">
+                                        <img :alt="repository.repo.owner.login"
+                                             :data-src="repository.repo.owner.avatar_url"
+                                             :src="repository.repo.owner.avatar_url">
                                     </div>
                                     <span class="owner-name">{{ repository.repo.owner.login }}</span>
                                     <div class="repository-name">{{ repository.repo.name }}</div>
@@ -59,9 +58,9 @@
 
                                     <div>
                                         <div class="language">
-                                            <img :src="loadingImgSrc"
-                                                 :data-src="languageIcon(repository.repo.language)"
-                                                 :alt="repository.repo.language">
+                                            <img :src="languageIcon(repository.repo.language)"
+                                                 :alt="repository.repo.language"
+                                                 :data-src="languageIcon(repository.repo.language)">
                                             <div>{{ repository.repo.language ? repository.repo.language : 'unknown' }}</div>
                                         </div>
                                         <div class="starred-at">

diff --git a/src/manifest.json b/src/manifest.json
@@ -19,7 +19,7 @@
         "unlimitedStorage",
         "activeTab",
         "tabs",
-        "https://api.github.com/*",
+        "https://*.github.com/*",
         "https://*.githubusercontent.com/*"
     ],
     "background": {