-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
In order to support multiple parameters of lambda, is this too compli… #37
Merged
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
13 changes: 4 additions & 9 deletions
13
netty-rpc-client/src/main/java/com/netty/rpc/client/proxy/RpcFunction.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,30 +1,25 @@ | ||
package com.netty.rpc.client.proxy; | ||
|
||
import java.io.Serializable; | ||
import java.lang.invoke.SerializedLambda; | ||
import java.lang.reflect.Method; | ||
|
||
/** | ||
* lambda method reference | ||
* g-yu | ||
* | ||
* @param <T> | ||
* @param <P> | ||
*/ | ||
@FunctionalInterface | ||
public interface RpcFunction<T, P> extends Serializable { | ||
public interface RpcFunction<T, P> extends SerializableFunction<T> { | ||
/** | ||
* have parameter | ||
* | ||
* @param t | ||
* @param p | ||
* @return | ||
*/ | ||
P apply(T t, P p); | ||
Object apply(T t, P p); | ||
|
||
|
||
default String getName() throws Exception { | ||
Method write = this.getClass().getDeclaredMethod("writeReplace"); | ||
write.setAccessible(true); | ||
SerializedLambda serializedLambda = (SerializedLambda) write.invoke(this); | ||
return serializedLambda.getImplMethodName(); | ||
} | ||
} |
5 changes: 5 additions & 0 deletions
5
netty-rpc-client/src/main/java/com/netty/rpc/client/proxy/RpcFunction2.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,5 @@ | ||
package com.netty.rpc.client.proxy; | ||
@FunctionalInterface | ||
public interface RpcFunction2<T, P1, P2> extends SerializableFunction<T> { | ||
Object apply(T t, P1 p1, P2 p2); | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
14 changes: 14 additions & 0 deletions
14
netty-rpc-client/src/main/java/com/netty/rpc/client/proxy/SerializableFunction.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,14 @@ | ||
package com.netty.rpc.client.proxy; | ||
|
||
import java.io.Serializable; | ||
import java.lang.invoke.SerializedLambda; | ||
import java.lang.reflect.Method; | ||
|
||
public interface SerializableFunction<T> extends Serializable { | ||
default String getName() throws Exception { | ||
Method write = this.getClass().getDeclaredMethod("writeReplace"); | ||
write.setAccessible(true); | ||
SerializedLambda serializedLambda = (SerializedLambda) write.invoke(this); | ||
return serializedLambda.getImplMethodName(); | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
这个地方,其实有个问题:就是服务端接口定义的时候是Integer,而客户端调用的时候如果传的是int,是匹配不上的。
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
从jdk相关反射显示上来看,func(Integer i) 跟func(int i) 这是两个方法,所以如果服务端跟客户端方法签名不一致会导致服务端找不到调用方法。