introduce ct for local helm install test

.github/workflows/helm.yaml

@@ -49,8 +49,7 @@ jobs:
 
       # Need a multi node cluster so descheduler runs until evictions
       - name: Create multi node Kind cluster
-        run: |
-          kind create cluster --name kind --config ./hack/kind_config.yaml --wait 2m
+        run: make kind-multi-node
 
       # helm-extra-set-args only available after ct 3.6.0
       - name: Run chart-testing (install)

Makefile

@@ -153,3 +153,6 @@ test-helm: ensure-helm-install
 
 kind-multi-node:
 	kind create cluster --name kind --config ./hack/kind_config.yaml --wait 2m
+
+ct-helm:
+	./hack/verify-chart.sh

docs/contributor-guide.md

@@ -39,18 +39,6 @@ make test-unit
 make test-e2e
 ```
 
-## Run Helm Tests
-Run the helm test for a particular descheduler release by setting below variables,
-```
-HELM_IMAGE_REPO="descheduler"
-HELM_IMAGE_TAG="helm-test"
-HELM_CHART_LOCATION="./charts/descheduler"
-```
-The helm tests runs as part of descheduler CI. But, to run it manually from the descheduler root,
-
-```
-make test-helm
-```
 
 ## Build Helm Package locally
 
@@ -68,5 +56,15 @@ To check linting of your changes in the helm chart locally you can run:
 make lint-helm
 ```
 
+## Test helm changes locally with kind and ct
+
+You will need kind and docker (or equivalent) installed. We can use ct public image to avoid installing ct and all its dependencies.
+
+
+```
+make kind-multi-node
+make ct-helm
+```
+
 ### Miscellaneous
 See the [hack directory](https://github.com/kubernetes-sigs/descheduler/tree/master/hack) for additional tools and scripts used for developing the descheduler.

hack/verify-chart.sh

@@ -0,0 +1 @@
+docker run -it --rm --network host --workdir=/data --volume ~/.kube/config:/root/.kube/config:ro --volume $(pwd):/data quay.io/helmpack/chart-testing:v3.7.0 /bin/bash -c "git config --global --add safe.directory /data; ct install --config=.github/ci/ct.yaml --helm-extra-set-args=\"--set=kind=Deployment --set=podSecurityPolicy.create=false\""