Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the lightning prefix from the lnInvoice #572

Merged
merged 6 commits into from
Aug 28, 2024

Conversation

danfercf1
Copy link
Contributor

Removing the lightning prefix from the commands file and the validation

Fixes #542

Copy link
Member

@Catrya Catrya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, upon attempting to run it, it fails and throws the following error: Cannot find module './bot_utils'

@danfercf1
Copy link
Contributor Author

Yes, you are right, I comitted the missed file

Copy link
Member

@Catrya Catrya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It works, but it is not necessary to create a new module just for that, but to keep the structure that is already there. You could move it to "util"

@danfercf1
Copy link
Contributor Author

I already moved it to the folder util and changed its name to camelcase format names

@danfercf1 danfercf1 requested a review from Catrya August 22, 2024 13:25
@Catrya
Copy link
Member

Catrya commented Aug 23, 2024

Hi @danfercf1 let's wait for @grunch to review and decides

util/valitationUtils.js Outdated Show resolved Hide resolved
@grunch
Copy link
Member

grunch commented Aug 25, 2024

Hi @danfercf1 let's wait for @grunch to review and decides

I think after move the new file to .ts we can merge

@danfercf1
Copy link
Contributor Author

I updated the new file to Typescript

@danfercf1 danfercf1 requested a review from knocte August 26, 2024 15:12
@grunch
Copy link
Member

grunch commented Aug 28, 2024

Hi @danfercf1 thank you for your contribution, before we merge it we need to have the conflict solved, validation.js file has just been moved to validation.ts

@danfercf1
Copy link
Contributor Author

Hi @danfercf1 thank you for your contribution, before we merge it we need to have the conflict solved, validation.js file has just been moved to validation.ts

I will take a look

@danfercf1
Copy link
Contributor Author

I updated the file validation.ts

@grunch grunch merged commit 5ae85c6 into lnp2pBot:main Aug 28, 2024
4 checks passed
@grunch
Copy link
Member

grunch commented Aug 29, 2024

Hey @danfercf1 because we have a buggy PR merged (#557) we need to revert this one, your code is ok I will include in a new version, thanks again

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove the prefix lightning:
4 participants