Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Convert ln to TS (6th commit of PR435)" #545

Merged
merged 1 commit into from
Jul 25, 2024

Conversation

grunch
Copy link
Member

@grunch grunch commented Jul 25, 2024

Reverts #541

This PR breaks paying pending payments:

0|roboto  | [2024-07-25T18:00:06.016+00:00] error: Unhandled Rejection: Error: 400: Bad Request: message to delete not found 
0|roboto  | [2024-07-25T18:00:06.730+00:00] error: isPendingPayment catch error: 400,ExpectedLndGrpcApiObjectToLookupPayment 
0|roboto  | [2024-07-25T18:00:06.734+00:00] error: isPendingPayment catch error: 400,ExpectedLndGrpcApiObjectToLookupPayment 
0|roboto  | [2024-07-25T18:00:06.738+00:00] error: payRequest: 400,ExpectedLndToDeleteForwardingReputations 
0|roboto  | [2024-07-25T18:00:10.364+00:00] error: isPendingPayment catch error: 400,ExpectedLndGrpcApiObjectToLookupPayment 
0|roboto  | [2024-07-25T18:00:10.366+00:00] error: isPendingPayment catch error: 400,ExpectedLndGrpcApiObjectToLookupPayment 
0|roboto  | [2024-07-25T18:00:10.368+00:00] error: payRequest: 400,ExpectedLndToDeleteForwardingReputations 
0|roboto  | [2024-07-25T18:00:10.897+00:00] error: isPendingPayment catch error: 400,ExpectedLndGrpcApiObjectToLookupPayment 
0|roboto  | [2024-07-25T18:00:10.900+00:00] error: isPendingPayment catch error: 400,ExpectedLndGrpcApiObjectToLookupPayment 
0|roboto  | [2024-07-25T18:00:10.901+00:00] error: payRequest: 400,ExpectedLndToDeleteForwardingReputations 
0|roboto  | [2024-07-25T18:00:11.373+00:00] error: isPendingPayment catch error: 400,ExpectedLndGrpcApiObjectToLookupPayment 
0|roboto  | [2024-07-25T18:00:11.375+00:00] error: isPendingPayment catch error: 400,ExpectedLndGrpcApiObjectToLookupPayment 
0|roboto  | [2024-07-25T18:00:11.377+00:00] error: payRequest: 400,ExpectedLndToDeleteForwardingReputations 
0|roboto  | [2024-07-25T18:00:11.840+00:00] error: isPendingPayment catch error: 400,ExpectedLndGrpcApiObjectToLookupPayment 
0|roboto  | [2024-07-25T18:00:11.842+00:00] error: isPendingPayment catch error: 400,ExpectedLndGrpcApiObjectToLookupPayment 
0|roboto  | [2024-07-25T18:00:11.844+00:00] error: payRequest: 400,ExpectedLndToDeleteForwardingReputations 
0|roboto  | [2024-07-25T18:00:12.317+00:00] error: isPendingPayment catch error: 400,ExpectedLndGrpcApiObjectToLookupPayment 
0|roboto  | [2024-07-25T18:00:12.329+00:00] error: isPendingPayment catch error: 400,ExpectedLndGrpcApiObjectToLookupPayment 
0|roboto  | [2024-07-25T18:00:12.332+00:00] error: payRequest: 400,ExpectedLndToDeleteForwardingReputations 
0|roboto  | [2024-07-25T18:00:15.857+00:00] error: isPendingPayment catch error: 400,ExpectedLndGrpcApiObjectToLookupPayment 
0|roboto  | [2024-07-25T18:00:15.859+00:00] error: isPendingPayment catch error: 400,ExpectedLndGrpcApiObjectToLookupPayment 
0|roboto  | [2024-07-25T18:00:15.861+00:00] error: payRequest: 400,ExpectedLndToDeleteForwardingReputations 
0|roboto  | [2024-07-25T18:00:16.467+00:00] error: isPendingPayment catch error: 400,ExpectedLndGrpcApiObjectToLookupPayment 
0|roboto  | [2024-07-25T18:00:16.470+00:00] error: isPendingPayment catch error: 400,ExpectedLndGrpcApiObjectToLookupPayment 
0|roboto  | [2024-07-25T18:00:16.471+00:00] error: payRequest: 400,ExpectedLndToDeleteForwardingReputations 
0|roboto  | [2024-07-25T18:00:16.986+00:00] error: isPendingPayment catch error: 400,ExpectedLndGrpcApiObjectToLookupPayment 
0|roboto  | [2024-07-25T18:00:16.989+00:00] error: isPendingPayment catch error: 400,ExpectedLndGrpcApiObjectToLookupPayment 
0|roboto  | [2024-07-25T18:00:16.992+00:00] error: payRequest: 400,ExpectedLndToDeleteForwardingReputations 
0|roboto  | [2024-07-25T18:00:17.477+00:00] error: isPendingPayment catch error: 400,ExpectedLndGrpcApiObjectToLookupPayment 
0|roboto  | [2024-07-25T18:00:17.482+00:00] error: isPendingPayment catch error: 400,ExpectedLndGrpcApiObjectToLookupPayment 
0|roboto  | [2024-07-25T18:00:17.485+00:00] error: payRequest: 400,ExpectedLndToDeleteForwardingReputations 
0|roboto  | [2024-07-25T18:00:18.307+00:00] error: isPendingPayment catch error: 400,ExpectedLndGrpcApiObjectToLookupPayment 
0|roboto  | [2024-07-25T18:00:18.311+00:00] error: isPendingPayment catch error: 400,ExpectedLndGrpcApiObjectToLookupPayment 
0|roboto  | [2024-07-25T18:00:18.318+00:00] error: payRequest: 400,ExpectedLndToDeleteForwardingReputations 

@grunch grunch merged commit 970ae84 into main Jul 25, 2024
6 checks passed
@grunch
Copy link
Member Author

grunch commented Jul 25, 2024

Hi @Mersho I had to revert this PR because it broke production on paying invoices to buyers, I need to test it more, sorry

@webwarrior-ws
Copy link
Contributor

@grunch How can I reproduce that error? Is it even possible with one Telegram account?

@webwarrior-ws
Copy link
Contributor

I was able to reproduce the error.

@webwarrior-ws
Copy link
Contributor

But I wasn't able to complete a payment on main branch either.

[2024-07-31T14:29:43.442+02:00] error: isPendingPayment catch error: 404,SentPaymentNotFound
[2024-07-31T14:29:43.506+02:00] error: payRequest: 503,PaymentPathfindingFailedToFindPossibleRoute
[2024-07-31T14:30:00.091+02:00] error: payRequest: 503,UnexpectedPaymentError,[object Object]
[2024-07-31T14:30:00.106+02:00] error: payRequest: 503,PaymentPathfindingFailedToFindPossibleRoute

@webwarrior-ws
Copy link
Contributor

Was able to complete a payment on main branch.

On #541, payment completed after 2 retries.
So it's not even a consistent error.

@grunch
Copy link
Member Author

grunch commented Aug 1, 2024

Was able to complete a payment on main branch.

On #541, payment completed after 2 retries. So it's not even a consistent error.

Hi @webwarrior-ws thank you for your testing, I think we should show this object, [2024-07-31T14:30:00.091+02:00] error: payRequest: 503,UnexpectedPaymentError,[object Object] to discover the origin of the bug, maybe is not a consistent error but we have 13k users, even an non consistent error will impact negatively to a huge amount of users

@webwarrior-ws
Copy link
Contributor

That PaymentPathfindingFailedToFindPossibleRoute might have been due to my Polar setup being broken (not enough channel capacity?).

Now it's like this:

[2024-08-05T14:05:00.117+02:00] error: isPendingPayment catch error: 400,ExpectedLndGrpcApiObjectToLookupPayment 
[2024-08-05T14:05:00.118+02:00] error: isPendingPayment catch error: 400,ExpectedLndGrpcApiObjectToLookupPayment 
[2024-08-05T14:05:00.120+02:00] error: payRequest: 400,ExpectedLndToDeleteForwardingReputations

Which doesn't tell much about source of the error.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants