Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

swap endianness when 16bit png #10

Merged
merged 1 commit into from
Mar 8, 2020
Merged

swap endianness when 16bit png #10

merged 1 commit into from
Mar 8, 2020

Conversation

gc-locks
Copy link

@gc-locks gc-locks commented Mar 6, 2020

No description provided.

@gc-locks gc-locks requested a review from ledyba-z March 6, 2020 13:11
@ledyba-z
Copy link
Contributor

ledyba-z commented Mar 8, 2020 •
edited
Loading

In avif-sample-images, there is hato.16bpc.png (16-bit PNG) and encoding-and-decoding tests pass daily. So there might be another something wrong.

Please give me a time to check details.

@ledyba-z
Copy link
Contributor

ledyba-z commented Mar 8, 2020

I found that hato.16bpc.png has the same value for upper 8bit and lower 8bit for each pixels.
I will update this 16bpc test file and check.
Please wait a moment.

ledyba-z
ledyba-z approved these changes Mar 8, 2020
View reviewed changes
Copy link
Contributor

@ledyba-z ledyba-z left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can reproduce the issue and check with new hato.16bpc.png .

LGTM, thanks!

@ledyba-z ledyba-z merged commit 61f1dc8 into link-u:master Mar 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ledyba-z ledyba-z ledyba-z approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gc-locks @ledyba-z