Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add FileMessage #65

Merged
merged 2 commits into from
Sep 12, 2017
Merged

Add FileMessage #65

merged 2 commits into from
Sep 12, 2017

Conversation

xsfishxs
Copy link
Contributor

Add file type message handling.

As described in docs: https://devdocs.line.me/en/#file-message

@be-hase
Copy link
Member

be-hase commented Sep 12, 2017

Thanks for your contribution. 👍

Please could you check these 3 points ?

1: Cloud you fix flake8 errors ?
https://travis-ci.org/line/line-bot-sdk-python/jobs/274501933#L555-L558

2: Have you already signed ICLA ?
https://feedback.line.me/enquete/public/919-h9Yqmr1u

3: If possible, I want the test code of parsing webhook.
for example,

2. Add test code for parsing webhook
@xsfishxs
Copy link
Contributor Author

Fixed :)

Copy link
Member

@be-hase be-hase left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, LGTM :D

@be-hase be-hase merged commit 982ea3d into line:master Sep 12, 2017
Renari pushed a commit to Renari/line-bot-sdk-python that referenced this pull request Nov 6, 2017
* Add FileMessage

* 1. Fix flake8 errors.
2. Add test code for parsing webhook
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants