Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix linter complaints #3334

Merged
merged 1 commit into from
Sep 25, 2024
Merged

Fix linter complaints #3334

merged 1 commit into from
Sep 25, 2024

Conversation

arik-so
Copy link
Contributor

@arik-so arik-so commented Sep 24, 2024

The linter is currently complaining about map_err where inspect_err is possible, as well as about a dependency_on_unit_never_type_fallback issue.

@tnull
Copy link
Contributor

tnull commented Sep 24, 2024

inspect_err doesn't exist on MSRV of 1.63, IIUC.

Allow `map_err` and `dependency_on_unit_never_type_fallback` pending
a future MSRV increase.
@arik-so arik-so changed the title WIP: Fix linter complaints Fix linter complaints Sep 24, 2024
@arik-so arik-so marked this pull request as ready for review September 24, 2024 04:41
@arik-so
Copy link
Contributor Author

arik-so commented Sep 24, 2024

Yup, changed it to suppressing the warnings instead.

Copy link

codecov bot commented Sep 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.10%. Comparing base (23109b6) to head (d340ac3).
Report is 6 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3334      +/-   ##
==========================================
+ Coverage   89.61%   90.10%   +0.48%     
==========================================
  Files         126      126              
  Lines      102690   106287    +3597     
  Branches   102690   106287    +3597     
==========================================
+ Hits        92028    95772    +3744     
+ Misses       7923     7842      -81     
+ Partials     2739     2673      -66     
Flag Coverage Δ
90.10% <ø> (+0.48%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@arik-so
Copy link
Contributor Author

arik-so commented Sep 24, 2024

Alternatively, we could run the linter on 1.63?

@arik-so arik-so requested a review from tnull September 25, 2024 02:00
@tnull tnull merged commit 5ce2442 into lightningdevkit:main Sep 25, 2024
20 of 21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants