Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce HID_API_MAX_REPORT_DESCRIPTOR_SIZE #452

Merged
merged 3 commits into from
Sep 15, 2022
Merged

Conversation

Youw
Copy link
Member

@Youw Youw commented Sep 10, 2022

  • first step is to use HID_API_MAX_REPORT_DESCRIPTOR_SIZE internally;
  • port a few improvements from get-descriptor branch early;

Resolves: #384

- first step is to use HID_API_MAX_REPORT_DESCRIPTOR_SIZE internally;
- port a few improvements from get-descriptor branch early;
@mcuee mcuee added the enhancement New feature or request label Sep 11, 2022
libusb/hid.c Outdated Show resolved Hide resolved
@JoergAtGithub
Copy link
Contributor

Is it intentional, that you removed dev->uses_numbered_reports from the hidraw backend, but not from the mac backend?

@Youw
Copy link
Member Author

Youw commented Sep 14, 2022

On hidraw I specifically touched the part that relates to it, and removed the whole thing, since it is not used.
On macOS I didn't even know the variable is there.
Alan left a lot of leftovers after him. We can only guess what was his intention back then.

@Youw Youw merged commit 4e63d6d into master Sep 15, 2022
@Youw Youw deleted the report-descriptor-upd branch September 15, 2022 10:05
fengjixuchui added a commit to fengjixuchui/hidapi that referenced this pull request Sep 15, 2022
Introduce HID_API_MAX_REPORT_DESCRIPTOR_SIZE (libusb#452)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

hid_open_path seems to ignore errors
3 participants