MSVC: crash bugfix when trying to open device without a serial number #194
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Youw
approved these changes
Oct 2, 2020
There was a problem hiding this comment.
Thanks much!
The only thing that bothers me, is the fact that we threat this kind of issues (no serial number) differently on different platforms.
E.g.: on macOS serial_number may be an empty string "", but it never be a null pointer.
But the fix definitely doesn't make things any worse.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently trying to call
hid_openon a device that doesn't have a serial number will result in a crash in the call to wcscmp here. Check that it's not null before calling wcscmp.