Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace all log.Err calls with log.AuditErr #1891

Merged
merged 4 commits into from
Jun 6, 2016

Conversation

benileo
Copy link
Contributor

@benileo benileo commented Jun 4, 2016

This PR replaces all calls to log.Err() with log.AuditErr() which has the same functionality.

Fixes #1543

@jsha
Copy link
Contributor

jsha commented Jun 6, 2016

I had forgotten that AuditErr takes an error rather than a string like the rest of these functions. That's a little awkward, and it encourages an antipattern of doing log.AuditErr(err) without adding any context. As you can see in this diff, most of the places we want to call it already use Sprintf to add some nice context.

As part of this change, could you change AuditErr to take a string like the other logging functions? And update the other call sites?

@benileo
Copy link
Contributor Author

benileo commented Jun 6, 2016

AuditErr now takes a string and all call sites have been updated.

@jsha jsha added the r=jsha label Jun 6, 2016
@jsha
Copy link
Contributor

jsha commented Jun 6, 2016

LGTM

@cpu
Copy link
Contributor

cpu commented Jun 6, 2016

LGTM 🍄.

@cpu cpu added the r=ccppuu label Jun 6, 2016
@cpu cpu merged commit 1336c42 into letsencrypt:master Jun 6, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants