Implement StripPrefix in wfe #1881
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Excellent, thanks! Will take a deeper look in the morning PST. |
| @@ -852,7 +847,7 @@ func (wfe *WebFrontEndImpl) Challenge( | |||
| // Challenge URIs are of the form /acme/challenge/<auth id>/<challenge id>. | |||
| // Here we parse out the id components. TODO: Use a better tool to parse out | |||
There was a problem hiding this comment.
Remove this TODO now, you've fixed it! :-)
|
LGTM modulo the one small comment there. @rolandshoemaker or @ccppuu can you do a second review? |
|
LGTM ✔️ |
|
Removed comment pertaining to this issue |
cpu
pushed a commit
that referenced
this pull request
Nov 19, 2016
We use `http.StripPrefix` so handlers don't have to deal with stripping the boring part of URLs that they don't need (#1881). This caused either an empty string or only the ID from the path to be logged as the `endpoint` which was not useful for debugging. By doing the logging in the constructor instead we still have access to the prefix part of the path and can use it to reconstruct the full path. Fixes #2328.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements
http.StripPrefixas a wrapper to the existing handler inwfe.go.StripPrefixis used to remove the path that it expects for each handler. Such as /acme/reg/. The remaining path is used as a slug, since multiple slugs are outside the scope of the specification.Several tests bypassed the
mux.Handle()and called the wrapped handler directly. ExRegistration. As a result of this, many tests had to be modified to no longer pass in the full path.request.URL.Pathshould now only ever contain the slug (if there is one).Fixes #437