Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Relax thor dependency #132

Merged
merged 1 commit into from
May 1, 2019
Merged

Relax thor dependency #132

merged 1 commit into from
May 1, 2019

Conversation

y-yagi
Copy link
Contributor

@y-yagi y-yagi commented Jun 3, 2018

@ninoseki
Copy link

I have Ruby projects that use Coveralls and Thor but because of 'thor', '~> 0.19.4’ restriction, I cannot use the latest version of Thor.
This PR solve that issue. So It would be great if you merge this PR.

@groot-gu
Copy link

+1

@y-yagi
Copy link
Contributor Author

y-yagi commented Jan 19, 2019

Rails 6.0.0 requires thor >= 0.20.3.
https://github.com/rails/rails/blob/3c6cfdf7adf4848976b7f425b1811d447b130f6a/railties/railties.gemspec#L40

This means that coveralls-ruby can not be used with Rails 6.0.0 unless this PR is merged.
Can anyone check this PR?

@shanecav84 shanecav84 mentioned this pull request Jan 19, 2019
Merged
@y-yagi
Copy link
Contributor Author

y-yagi commented Apr 28, 2019

Just a friendly ping

@shanecav84
Copy link

@nickmerwin

@nickmerwin
Copy link
Member

nickmerwin commented May 1, 2019 •
edited
Loading

Hi @y-yagi and @shanecav84 apologies for the delay -- could you please have a look at the Travis failures?

https://travis-ci.org/lemurheavy/coveralls-ruby/jobs/481620882

EDIT: nm, a restart on Travis fixed the build. Merging now.

@nickmerwin nickmerwin merged commit 0a86f96 into lemurheavy:master May 1, 2019
@shanecav84
Copy link

Thanks, @nickmerwin!

1 similar comment
@y-yagi
Copy link
Contributor Author

y-yagi commented May 1, 2019

Thanks, @nickmerwin!

@y-yagi y-yagi deleted the relax_thor_dependency branch May 1, 2019 20:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@y-yagi @ninoseki @groot-gu @shanecav84 @nickmerwin