Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mac binary signing tweaks #7988

Merged
merged 3 commits into from
Mar 30, 2023
Merged

Mac binary signing tweaks #7988

merged 3 commits into from
Mar 30, 2023

Conversation

palerdot
Copy link
Contributor

@palerdot palerdot commented Mar 29, 2023

Problem:

Mac app signing with binaries (like 7zip) fails. Related to #7934

Solution

Tweaking mac plist configuration to allow mac signing to include external binaries.

  <dict>
    <!-- This option is missing in ./build-mac/entitlements.mac.inherit.plist -->
    <key>com.apple.security.cs.disable-library-validation</key>
    <true/>
  </dict>

and in mac configuration for electron-builder

{
  "gatekeeperAssess": false,
}

Reference:

Some other related links that solved the same problem by including com.apple.security.cs.disable-library-validation

@palerdot palerdot marked this pull request as ready for review March 30, 2023 05:42
@palerdot palerdot requested a review from laurent22 March 30, 2023 05:42
@laurent22
Copy link
Owner

Hmm, I'm not sure this will work. If we disable security checks it's likely something's not going to go smoothly, but let's try anyway

@laurent22 laurent22 merged commit cf40089 into dev Mar 30, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Mar 30, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants