Mobile: Fix unable to show multiple WebViews at once #6841
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Seems like a good enough solution for now, especially since we don't have that many webviews |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Before this PR,
ExtendedWebViewalways wrote html toNoteEditor.html, regardless of what the WebView was being used for.As a result, if multiple
ExtendedWebViews were created at roughly the same time, allExtendedWebViews would use the same file and thus display the same content.Other possible solutions
webviewInstanceIdis required to separate WebViews. An alternative solution would be to create a new temporary file for each instance of the WebView. If we do this, these temporary files would need to be cleaned up/deleted when exiting the application.