Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

All: Seperate allPossibleCategories to @joplin/lib #6754

Merged
merged 8 commits into from
Sep 9, 2022
Merged

All: Seperate allPossibleCategories to @joplin/lib #6754

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
358b045
seperate allPossibleCategories to @joplin/lib
Retr0ve Aug 16, 2022
c839b30
update
Retr0ve Aug 18, 2022
9bab91b
update @joplin/lib version
Retr0ve Aug 18, 2022
f3cc0e6
Merge branch 'dev' into dev-category
Retr0ve Aug 30, 2022
0fcf2f4
Merge branch 'laurent22:dev' into dev-category
Retr0ve Sep 5, 2022
3d3b870
fix: typo
Retr0ve Sep 6, 2022
793321d
fix: small fix
Retr0ve Sep 6, 2022
aa8ff7e
fix: lint
Retr0ve Sep 6, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix: typo
  • Loading branch information
@Retr0ve
Retr0ve committed Sep 6, 2022
commit 3d3b87040a9d8268616a4d4ba475a182bcc94e01
2 changes: 1 addition & 1 deletion packages/generator-joplin/generators/app/templates/webpack.config.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,7 +73,7 @@ function validateCategories(categories) {
if (!categories) return null;
if ((categories.length !== new Set(categories).size)) throw new Error('Repeated categories are not allowed');
categories.forEach(category => {
if (!allPossibleCategories.map(category => { return category.name; }).includes(category)) throw new Error(`${category} is not a valid category. Please make sure that the category name is lowercase. Valid Categories are: \n${allPossibleCategories}\n`);
if (!allPossibleCategories.map(category => { return category.name; }).includes(category)) throw new Error(`${category.name} is not a valid category. Please make sure that the category name is lowercase. Valid categories are: \n${allPossibleCategories}\n`);
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

throw new Error(`${category.name}

In fact it should be "category" here, not "category.name", isn't it? It doesn't look like you have tested or even read your code at all. I made a mistake by suggesting this change, but you need to be responsible for what you're doing and not rely on reviewers.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested and fixed now

});
}

Expand Down