Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds support to toggle the sidebar. #424

Merged
merged 1 commit into from
Apr 16, 2018
Merged

Adds support to toggle the sidebar. #424

merged 1 commit into from
Apr 16, 2018

Conversation

Abijeet
Copy link
Contributor

@Abijeet Abijeet commented Apr 15, 2018

Closes #183

Please find the image below. Note that I've made Toggle sidebar the first item in the Menubar since it made sense for it to be there. Let me know if you want to move it.

Toggle Sidebar - Joplin

VSCode has removed some trailing white spaces, hope that's OK.

Signed-off-by: Abijeet abijeetpatro@gmail.com

Closes #183

Signed-off-by: Abijeet <abijeetpatro@gmail.com>
@Abijeet Abijeet changed the title [WIP] Adds support to toggle the sidebar. Adds support to toggle the sidebar. Apr 15, 2018
@Abijeet Abijeet mentioned this pull request Apr 15, 2018
8 tasks
@laurent22
Copy link
Owner

That's great, thanks for the pull request. Both the feature and implementation look very good, and I agree the icon should go to the left. I'm going to merge to do some tests and it should go in the next version.

@laurent22 laurent22 merged commit 02bde2c into laurent22:master Apr 16, 2018
@AbijeetP
Copy link

Hi @laurent22,

Couple of things,

  1. I should add a menu item under View that toggles the sidebar.
  2. Add a shortcut to toggle the sidebar. Any shortcuts in mind? How about Ctrl + S?.

I will do this either today or tomorrow and submit another PR.

PS: This is my office account

@laurent22
Copy link
Owner

Ok please take the latest code from master as I've made a small change to your code (rotating the icon when toggling the state).

For the shortcut, Ctrl+S should be reserved for saving even though we aren't using it yet. Evernote uses F10 for this - how about it?

@AbijeetP
Copy link

@laurent22 - Sorry, yea, Ctrl + S was a dumb suggestion. F10 sounds fine, will use that instead.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants