Desktop: Codemirror clean up list indent code #3581
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
disable smart enter handling for multiline selections (it was too complicated to keep track of) Fix other whitespace checks to also check start of string Update xml check to reflect that we now use markdown mode not gfm
also make tab behavior normal for non-empty lists
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This looks like a lot of changes but it's just because diff get's confused when I added a wrapper call to
cm.overlaywhich batches updates for slightly better performance.The main change here is that I disabled the smart
insertListElementcode when there are multiple cursors. It just becomes too difficult to track the correct behaviour.I also mixed in a couple of fixes to this file that I noticed, namely the whitespace regex I updated in a different pull was being used 3 times and I didn't update for all of them. It's all good now though.