Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Imagick to the php runtimes #559

Merged
merged 4 commits into from
Mar 1, 2023
Merged

Conversation

ams-ryanolson
Copy link
Contributor

@ams-ryanolson ams-ryanolson commented Feb 26, 2023

I am suggesting adding phpx.x-imagick to the dockerfile for each runtime. The reason this would help others is Imagick is quite common in its use when it comes to using Intervention, Spatie packages as well as general image manipulation. This would save a lot of time and stress for people having to customize their dockerfile. By preventing one-off customizations a lot of issues will be alleviated from various issue reports.

I did test this on each runtime and there are no errors or deployment issues.

Added php8.2-imagick into the docker file as this is a very common package used by multiple services
@taylorotwell
Copy link
Member

Are you sure this is all that is needed. For example on Forge we also run:

apt-get install -y --force-yes libmagickwand-dev

@ams-ryanolson
Copy link
Contributor Author

yes you do not need that. Please see reference

https://packages.debian.org/buster/libmagickwand-dev

The main thing to know is Imagick will install whatever dependencies it needs during install but for a functional system without turning Sail into a massive one-off solution, all that is needed is imagick.

I have tested this on all php versions with Intervention, Spatie Media Library, Spatie Image and direct imagick manipulation just to make sure there were no standards deps missing.

@taylorotwell taylorotwell merged commit fd8d04b into laravel:1.x Mar 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants