Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix annotation reply is null #7103

Merged
merged 1 commit into from
Aug 8, 2024
Merged

fix annotation reply is null #7103

merged 1 commit into from
Aug 8, 2024

Conversation

aerok
Copy link
Contributor

@aerok aerok commented Aug 8, 2024 •
edited
Loading

Checklist:

Important

Please review the checklist below before submitting your pull request.

  • Please open an issue before creating a PR or link to an existing issue
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I ran dev/reformat(backend) and cd web && npx lint-staged(frontend) to appease the lint gods

Description

Fixes #7101

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update, included: Dify Document
  • Improvement, including but not limited to code refactoring, performance optimization, and UI/UX improvement
  • Dependency upgrade

Testing Instructions

  • Annotated content
    image

  • Hits testing
    image

@dosubot dosubot bot added size:XS This PR changes 0-9 lines, ignoring generated files. 🐞 bug Something isn't working labels Aug 8, 2024
@aerok aerok closed this Aug 8, 2024
@aerok aerok reopened this Aug 8, 2024
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Aug 8, 2024
@crazywoola crazywoola self-requested a review August 8, 2024 09:00
crazywoola
crazywoola reviewed Aug 8, 2024
View reviewed changes
Copy link
Member

@crazywoola crazywoola left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems just reformat the code?

@aerok
Copy link
Contributor Author

aerok commented Aug 8, 2024 

and message.event.metadata

@crazywoola crazywoola merged commit ad682c3 into langgenius:main Aug 8, 2024
6 checks passed
ZhouhaoJiang added a commit that referenced this pull request Aug 9, 2024
@ZhouhaoJiang
Merge branch 'deploy/dev' of https://github.com/langgenius/dify into …
1c3612c 
…deploy/dev

* 'deploy/dev' of https://github.com/langgenius/dify: (42 commits)
  fix: account delete function
  chore: improve Vietnamese (vi-VN) translations (#7127)
  Update i18n/ja-JP/dataset-documents.ts "embeddedSpend" value. (#7124)
  update stepfun model (#7118)
  feat: wenxin add yi-34b-chat (#7117)
  fix annotation reply is null (#7103)
  feat: Postgres max connections (#7067)
  feat: add zhipu embedding-3 (#7100)
  feat: add text-embedding functon and LLM models to Siliconflow (#7090)
  extract docx filter comment element (#7092)
  fix: refine the tooltip component
  fix: only update&request sso settings when enabled
  fix: workflow search blocks (#7097)
  feat: app icon enhancements (#7095)
  workflow logs support workflow run id filter (#6833)
  fix: set enable_web_sso_switch_component default value to false
  feat: add a builtin tool to support regex extraction. (#7081) (#7087)
  add nltk punkt resource (#7063)
  Feat/add 360-zhinao provider (#7069)
  feat: Poetry requests timeout (#7086)
  ...
@ZuzooVn ZuzooVn mentioned this pull request Aug 15, 2024
Merged
4 tasks
cuiks pushed a commit to cuiks/dify that referenced this pull request Sep 2, 2024
@aerok @cuiks
fix annotation reply is null (langgenius#7103)
5b046a8
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@crazywoola crazywoola crazywoola approved these changes

Assignees
No one assigned
Labels
🐞 bug Something isn't working lgtm This PR has been approved by a maintainer size:XS This PR changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Annotation reply is null
2 participants
@aerok @crazywoola