Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GL related tests on linux getting skipped on CI recently #266

Open
HinTak opened this issue Sep 20, 2024 · 2 comments · May be fixed by #267
Open

GL related tests on linux getting skipped on CI recently #266

HinTak opened this issue Sep 20, 2024 · 2 comments · May be fixed by #267

Comments

@HinTak
Copy link
Collaborator

HinTak commented Sep 20, 2024

@kyamagu it looks like the largest number of passed tests on CI is mac os x at the moment (110 skipped), and I just noticed that most of the GL related tests are being skipped on Linux (300+ skipped). So this is the opposite situation before the recent GL related fix for mac os x. I suspect the new GL settings doesn't quite work against Xvfb. I haven't noticed / checked CI as pytest gives 100- skipped on my own linux box. Probably a Xvfb issue there (Xvfb does not support higher GL versions). To investigate.
@HinTak
Copy link
Collaborator Author

HinTak commented Sep 20, 2024

Unfortunately CI only keeps logs for 3 months so we don't know when it happened. I'll need to run the older release fresh on my playground to find out. Probably not important as the new GL versions work against real X.

@HinTak HinTak changed the title Gl related tests on linux getting skipped on CI recently GL related tests on linux getting skipped on CI recently Sep 20, 2024
HinTak added a commit to HinTak/skia-python that referenced this issue Sep 20, 2024
@HinTak
Make GL version setting specific to Mac OS only
5cba584 
Refining earlier change (kyamagu#214). It turns out that Xvfb's GL behavior on Linux
differ depending on whether there is actual graphic hardware or entirely
headless. The Apple GL settings works on Xvfb on my computer
(AMD Radeon R5 Graphics), but fails in github headless CI.

Fixes kyamagu#266
@HinTak HinTak linked a pull request Sep 20, 2024 that will close this issue
Open
@HinTak
Copy link
Collaborator Author

HinTak commented Sep 20, 2024 •
edited
Loading

`with #267, CI on x86_64 Linux is back to:

2115 passed, 98 skipped, 11 xfailed, 27 warnings

That mostly only affects "no-graphic hardware" linux use. For the next release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Make GL version setting specific to Mac OS only HinTak/skia-python
1 participant
@HinTak