Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix testing utils & cache digest & docs related to presets #787

Merged
merged 9 commits into from
Oct 6, 2018
Merged

Fix testing utils & cache digest & docs related to presets #787

merged 9 commits into from
Oct 6, 2018

Conversation

huafu
Copy link
Collaborator

@huafu huafu commented Oct 3, 2018 •
edited
Loading

  • fixes test helpers and other utils so they are compatible to any tsconfig
  • updated the doc
  • improved cli (some old code which didn't get into master for some unknown reason)
  • include the list of containing project's defined dependencies and their version in the cache digest generation

@huafu huafu added this to the 23.10.4 milestone Oct 3, 2018
@huafu huafu changed the title Fix testing utils Fix testing utils & docs related to presets Oct 3, 2018
@coveralls
Copy link

coveralls commented Oct 3, 2018 •
edited
Loading

Pull Request Test Coverage Report for Build 1975

  • 95 of 99 (95.96%) changed or added relevant lines in 8 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.5%) to 90.919%
Changes Missing Coverage Covered Lines Changed/Added Lines %
src/cli/config/migrate.ts 16 17 94.12%
src/config/config-set.ts 18 19 94.74%
src/cli/config/init.ts 20 22 90.91%
Totals Coverage Status
Change from base Build 1966: -0.5%
Covered Lines: 1088
Relevant Lines: 1138
💛 - Coveralls

@huafu huafu mentioned this pull request Oct 3, 2018
Closed
@huafu huafu requested a review from kulshekhar October 4, 2018 05:41
@huafu huafu changed the title Fix testing utils & docs related to presets Fix testing utils & cache digest & docs related to presets Oct 6, 2018
@huafu
fix(helpers): deprecate import from ts-jest, now ts-jest/utils
33ff29f 
Importing from `ts-jest` everything will possibly make collision with
future jest API. Also any star export or import might not be compatible
with the target project. Now all helpers to be used in tests or config
files have been moved to `ts-jest/utils`. Original ones have been kept
in `ts-jest` for now, with a deprecation warning when using them.

Closes kulshekhar#782
@huafu
fix(cli): change options to better reflect the new presets
68abcfb
@huafu
test(preset): updates tests related to presets
8d5a60a
@huafu
docs(utils): updates docs related to moved helpers
ec78757
@huafu
test(preset): fixes tests, doc and cli for presets
7b2dd01
@huafu
fix(cache): adds project's dep versions to cache key
6cacbea 
Includes the real version of each dependency of the containing project
in the cache key digest calculation.

Closes kulshekhar#785
@huafu
test(typings): repalce jest.SpyInstance with MockInstance
b837acd
@huafu huafu mentioned this pull request Oct 6, 2018
Closed
GeeWee
GeeWee requested changes Oct 6, 2018
View reviewed changes
src/cli/config/init.ts Outdated Show resolved Hide resolved
GeeWee
GeeWee requested changes Oct 6, 2018
View reviewed changes
Copy link
Collaborator

@GeeWee GeeWee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to fix some ternaries but otherwise good.

@huafu huafu removed the request for review from kulshekhar October 6, 2018 08:07
GeeWee
GeeWee approved these changes Oct 6, 2018
View reviewed changes
Copy link
Collaborator

@GeeWee GeeWee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@huafu huafu merged commit 90beca8 into kulshekhar:master Oct 6, 2018
@huafu huafu deleted the fix-testing-utils branch October 6, 2018 11:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GeeWee GeeWee GeeWee approved these changes

Assignees
No one assigned
Labels
Documentation 📖
Projects
None yet
Milestone
23.10.4
Development

Successfully merging this pull request may close these issues.
3 participants
@huafu @coveralls @GeeWee