Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(devs-infra): update website deps #3081

Merged
merged 1 commit into from
Nov 19, 2021
Merged

docs(devs-infra): update website deps #3081

merged 1 commit into from
Nov 19, 2021

Conversation

ahnpnl
Copy link
Collaborator

@ahnpnl ahnpnl commented Nov 19, 2021

Test plan

Green CI

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

N.A.

@coveralls
Copy link

Pull Request Test Coverage Report for Build 1481454301

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 94.118%

Totals Coverage Status
Change from base Build 1480258790: 0.0%
Covered Lines: 1152
Relevant Lines: 1179

💛 - Coveralls

Repository owner deleted a comment from coveralls Nov 19, 2021
@kulshekhar
Copy link
Owner

is there a clear benefit to doing this?

My immediate concern is docs being updated such that readers can't copy paste directly from them if they're using json (because of the single quotes there)

@ahnpnl
Copy link
Collaborator Author

ahnpnl commented Nov 19, 2021

Ah I see, I think prettier did the format automatically to single quote. Hmm gonna check why prettier does that.

@ahnpnl ahnpnl changed the title docs(devs-infra): update website deps and replace json with json5 docs(devs-infra): update website deps Nov 19, 2021
@ahnpnl
Copy link
Collaborator Author

ahnpnl commented Nov 19, 2021

ok turned out it's not possible to distinguish in markdown with Prettier to know which one is json5, which is js. So we have to stick with json, Jest documentation also does that.

@ahnpnl ahnpnl merged commit bacd6af into kulshekhar:main Nov 19, 2021
@ahnpnl ahnpnl deleted the update-docs branch November 19, 2021 22:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants