Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build(devs-infra): improve type generation script #2492

Merged
merged 1 commit into from
Apr 5, 2021
Merged

build(devs-infra): improve type generation script #2492

merged 1 commit into from
Apr 5, 2021

Conversation

ahnpnl
Copy link
Collaborator

@ahnpnl ahnpnl commented Apr 4, 2021

Summary

Improve raw compiler options type definition generation script

Test plan

Adjust post-build script to verify to do the check

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

N.A.

@coveralls
Copy link

coveralls commented Apr 4, 2021 •
edited
Loading

Pull Request Test Coverage Report for Build 716510188

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 93.938%
Totals Coverage Status
Change from base Build 710851819: 0.0%
Covered Lines: 998
Relevant Lines: 1028
💛 - Coveralls

@ahnpnl ahnpnl marked this pull request as ready for review April 4, 2021 11:57
@ahnpnl ahnpnl requested a review from kulshekhar as a code owner April 4, 2021 11:57
@ahnpnl ahnpnl merged commit 558e49b into kulshekhar:master Apr 5, 2021
@ahnpnl ahnpnl deleted the type-generation-improve branch April 5, 2021 10:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kulshekhar kulshekhar kulshekhar approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ahnpnl @coveralls @kulshekhar