Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(dev-infra): add versioning to doc and improve homepage #2323

Merged
merged 1 commit into from
Feb 5, 2021
Merged

docs(dev-infra): add versioning to doc and improve homepage #2323

merged 1 commit into from
Feb 5, 2021

Conversation

ahnpnl
Copy link
Collaborator

@ahnpnl ahnpnl commented Feb 5, 2021

Summary

  • Make homepage a bit fancier
  • Add versioning for documentation
  • Add PWA to documentation site

Revamped home page
image

Test plan

Green CI

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

N.A.

@coveralls
Copy link

coveralls commented Feb 5, 2021

Pull Request Test Coverage Report for Build 540651359

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 93.629%

Totals Coverage Status
Change from base Build 539684288: 0.0%
Covered Lines: 945
Relevant Lines: 975

💛 - Coveralls

@ahnpnl ahnpnl marked this pull request as ready for review February 5, 2021 14:13
@ahnpnl
Copy link
Collaborator Author

ahnpnl commented Feb 5, 2021

@kulshekhar what do you think xD ? Does the new home page look more tempting 😃

@kulshekhar
Copy link
Owner

This looks great @ahnpnl 👍

@ahnpnl ahnpnl merged commit 2ab1e44 into kulshekhar:master Feb 5, 2021
@ahnpnl ahnpnl deleted the improve-doc branch February 5, 2021 16:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants