Watch bookmarks to GA #17026

wojtek-t · 2019-10-18T12:40:03Z

Ref kubernetes/enhancements#956

/assign @lavalamp @deads2k @liggitt

k8sio-netlify-preview-bot · 2019-10-18T12:40:10Z

Deploy preview for kubernetes-io-vnext-staging processing.

Building with commit 4190e2e

https://app.netlify.com/sites/kubernetes-io-vnext-staging/deploys/5dad8db627f1d700073b10c7

lavalamp · 2019-10-18T16:36:54Z

/lgtm

kbhawkey · 2019-10-18T17:55:25Z

content/en/docs/reference/command-line-tools-reference/feature-gates.md

@@ -152,7 +152,8 @@ different Kubernetes components.
 | `VolumeSubpathEnvExpansion` | `true` | Beta | 1.15 | |
 | `VolumeSnapshotDataSource` | `false` | Alpha | 1.12 | - |
 | `WatchBookmark` | `false` | Alpha | 1.15 | 1.15 |
-| `WatchBookmark` | `true` | Beta | 1.16 | |
+| `WatchBookmark` | `true` | Beta | 1.16 | 1.16 |
+| `WatchBookmark` | `true` | GA | 1.17 | - |


hello @wojtek-t . Recently, a second table was added for features that have reached GA. If WatchBookmark is reaching GA (1.17), then the three Watch entries belong in the second table. @tengqm , should be able to confirm.

kbhawkey · 2019-10-18T17:59:49Z

content/en/docs/reference/using-api/api-concepts.md

@@ -89,8 +89,6 @@ A given Kubernetes server will only preserve a historical list of changes for a

 ### Watch bookmarks

-{{< feature-state for_k8s_version="v1.16" state="beta" >}}
-
 To mitigate the impact of short history window, we introduced a concept of `bookmark` watch event. It is a special kind of event to pass an information that all changes up to a given `resourceVersion` client is requesting has already been send. Object returned in that event is of the type requested by the request, but only `resourceVersion` field is set, e.g.:


@wojtek-t , do you think it would be worthwhile to update the feature-state shortcode (version=v1.17, state=stable)?

I'm not sure - I don't think we state the feature status for GA features.

It's not mandatory, but when features go GA it's handy to signal that to readers. Stating stability from v1.17 also nudges people to upgrade if they want the feature.
(after adding this kind of labelling it eventually needs cleanup - which is a job for a bot).

wojtek-t

PTAL

wojtek-t · 2019-10-21T10:50:47Z

content/en/docs/reference/command-line-tools-reference/feature-gates.md

@@ -152,7 +152,8 @@ different Kubernetes components.
 | `VolumeSubpathEnvExpansion` | `true` | Beta | 1.15 | |
 | `VolumeSnapshotDataSource` | `false` | Alpha | 1.12 | - |
 | `WatchBookmark` | `false` | Alpha | 1.15 | 1.15 |
-| `WatchBookmark` | `true` | Beta | 1.16 | |
+| `WatchBookmark` | `true` | Beta | 1.16 | 1.16 |
+| `WatchBookmark` | `true` | GA | 1.17 | - |


wojtek-t · 2019-10-21T10:51:18Z

content/en/docs/reference/using-api/api-concepts.md

@@ -89,8 +89,6 @@ A given Kubernetes server will only preserve a historical list of changes for a

 ### Watch bookmarks

-{{< feature-state for_k8s_version="v1.16" state="beta" >}}
-
 To mitigate the impact of short history window, we introduced a concept of `bookmark` watch event. It is a special kind of event to pass an information that all changes up to a given `resourceVersion` client is requesting has already been send. Object returned in that event is of the type requested by the request, but only `resourceVersion` field is set, e.g.:


I'm not sure - I don't think we state the feature status for GA features.

kbhawkey · 2019-10-21T13:00:56Z

Page preview:
https://deploy-preview-17026--kubernetes-io-vnext-staging.netlify.com/docs/reference/command-line-tools-reference/feature-gates/

/lgtm

kbhawkey · 2019-10-23T13:21:21Z

/cc @daminisatya

tengqm · 2019-10-28T01:45:47Z

/lgtm

daminisatya · 2019-11-02T02:26:27Z

/lgtm
/approve

k8s-ci-robot · 2019-11-02T02:27:04Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: daminisatya

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~content/en/OWNERS~~ [daminisatya]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

daminisatya · 2019-11-07T03:46:03Z

/milestone 1.17

* feat: graduate TaintNodesByCondition to GA (#17073) * Promote StartupProbe to beta (enabled by default). (#17164) * Watch bookmarks to GA (#17026) * feat: graduate ScheduleDaemonSetPods to GA (#17350) * Update Docker installation instructions (#17405) * Use exact version numbers for installing Docker in Ubuntu (#17428) * Move CSIMigration and CSIMigrationGCE to Beta in Kubernetes v1.17 (#17478) * Promote NodeLease feature to GA (#17189) * Update docs for csi topology ga (#17408) * Update RunAsUsername to beta (#17460) * doc:Update RunAsUsername to beta * doc: update samples - kubernetes.io/os is no longer beta * Updating based on review feedback * Promote Node-specific volume limits to GA (#17432) * Promote PodShareProcessNamespace to stable (#17192) * Promote PodShareProcessNamespace to stable * Add for_k8s_version to feature-state label Co-Authored-By: Tim Bannister <tim@scalefactory.com> * Readd version-check to shareProcessNamespace task * Update service load balancer finalizer doc for GA (#17438) * Update Topology Manager docs (#17451) * Added information on how device plugins can take advantage of Topology Manager * Updated the Topology Manager documentation to include additionalinformation and update some out of date sections * Fix broken Topology Manager link (#17746) Part of What's Next Device Plugin section * Update CRD defaulting docs for GA (#17450) * Add documentation for VolumeSnapshot Beta (#17233) * Updating EndpointSlice documentation for beta release in 1.17 (#17411) * (docs/dualstack): v1.17 updates (#17457) * Add placehold doc updates for dualstack in 1.17 Signed-off-by: Lachlan Evenson <lachlan.evenson@microsoft.com> * Add Downward API and /etc/hosts Pod IP validation Signed-off-by: Lachlan Evenson <lachlan.evenson@microsoft.com> * remove addressed known issue via k/k pr 85246 Signed-off-by: Lachlan Evenson <lachlan.evenson@microsoft.com> * Remove known issue and add flag as part of k/k 79993 Signed-off-by: Lachlan Evenson <lachlan.evenson@microsoft.com> * remove follow up placeholders Signed-off-by: Lachlan Evenson <lachlan.evenson@microsoft.com> * Update verbiage Signed-off-by: Lachlan Evenson <lachlan.evenson@microsoft.com> * Make IP addressing consistent throughout the task Signed-off-by: Lachlan Evenson <lachlan.evenson@microsoft.com> * Update to status.podIPs Signed-off-by: Lachlan Evenson <lachlan.evenson@microsoft.com> * Update content/en/docs/tasks/network/validate-dual-stack.md Use set instead of env Co-Authored-By: Khaled Henidak (Kal) <khnidk@outlook.com> * add topology.kubernetes.io/zone, topology.kubernetes.io/region and node.kubernetes.io/instance-type labels to docs (#17498) Signed-off-by: Andrew Sy Kim <kiman@vmware.com> * Service topology alpha documentation (#17459) * Update list of feature flags for in-tree plugins migrated to CSI (#17533) Signed-off-by: Deep Debroy <ddebroy@docker.com> * Update Node concept for TaintNodesByCondition going GA (#17577) * feat: graduate ResourceQuotaScopeSelectors to GA in 1.17 (#17554) * kubeadm: update the upgrade documentation for 1.17 (#17587) * doc: Simplify Windows deployments with RuntimeClass (#16697) * doc: Simplify Windows deployments with RuntimeClass * Updating on review feedback * doc: Adding windows-build label from enhancement 1301 * update doc for kubelet option --reserved-cpus (#17648) * feat: update TaintNodesByCondition in feature gates table (#17377) * Update docs for v1 resource quota configuration (#17547) * AdmissionConfiguration v1 (#17548) * Update WebhookAdmissionConfiguration examples (#17549) * Update AWS EBS Migration Feature state (#16126) * Add resource version section to api-concepts documentation (#16910) * Add Resource Version semantics section to api concepts * Clarify risks of going back in time, add details about compaction and watch cache sizes * Apply suggestions from liggitt Co-Authored-By: Jordan Liggitt <jordan@liggitt.net> * remove pesudocode, apply feedback * Fix typo * Clarify equality rules * Cleanup kubectl generators docs (#17609) * Write ReplicationController without a space * Drop mentioning unsupported cluster versions * Fix capitalization for “API group” * Tweak wording * Avoid using deprecated generator in example * add Antrea description in dev-1.17 (#17919) * Promote VolumeSubpathEnvExpansion to GA * Reference Documentation for the Kubernetes API for 1.17 (#18019) * Update feature-gates.md (#18033) * Reference Documentation for kubectl Commands for 1.17 (#18017) * Update for v1.17 (#18034) * Update config.toml(release-1.17) for 1.17 (#18031)

k8s-ci-robot assigned deads2k, lavalamp and liggitt Oct 18, 2019

k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Oct 18, 2019

k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Oct 18, 2019

k8s-ci-robot requested review from Rajakavitha1 and smarterclayton October 18, 2019 12:40

k8s-ci-robot added language/en Issues or PRs related to English language sig/docs Categorizes an issue or PR as relevant to SIG Docs. labels Oct 18, 2019

k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 18, 2019

kbhawkey reviewed Oct 18, 2019

View reviewed changes

Watch bookmarks to GA

4190e2e

wojtek-t force-pushed the watch_bookmarks_ga branch from b4297e2 to 4190e2e Compare October 21, 2019 10:51

k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 21, 2019

wojtek-t commented Oct 21, 2019

View reviewed changes

k8s-ci-robot assigned kbhawkey Oct 21, 2019

k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 21, 2019

wojtek-t mentioned this pull request Oct 22, 2019

Add Watch Bookmarks support kubernetes/enhancements#956

Closed

k8s-ci-robot requested a review from daminisatya October 23, 2019 13:21

k8s-ci-robot assigned tengqm Oct 28, 2019

k8s-ci-robot assigned daminisatya Nov 2, 2019

k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 2, 2019

k8s-ci-robot merged commit 740a038 into kubernetes:dev-1.17 Nov 2, 2019

k8s-ci-robot added this to the 1.17 milestone Nov 7, 2019

mrbobbytables pushed a commit that referenced this pull request Dec 6, 2019

Watch bookmarks to GA (#17026)

8779783

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Watch bookmarks to GA #17026

Watch bookmarks to GA #17026

wojtek-t commented Oct 18, 2019

k8sio-netlify-preview-bot commented Oct 18, 2019 •

edited

Loading

lavalamp commented Oct 18, 2019

kbhawkey Oct 18, 2019

wojtek-t Oct 21, 2019

kbhawkey Oct 18, 2019

wojtek-t Oct 21, 2019

sftim Oct 27, 2019

wojtek-t left a comment

wojtek-t Oct 21, 2019

wojtek-t Oct 21, 2019

kbhawkey commented Oct 21, 2019

kbhawkey commented Oct 23, 2019

tengqm commented Oct 28, 2019

daminisatya commented Nov 2, 2019

k8s-ci-robot commented Nov 2, 2019

daminisatya commented Nov 7, 2019

Watch bookmarks to GA #17026

Watch bookmarks to GA #17026

Conversation

wojtek-t commented Oct 18, 2019

k8sio-netlify-preview-bot commented Oct 18, 2019 • edited Loading

lavalamp commented Oct 18, 2019

kbhawkey Oct 18, 2019

Choose a reason for hiding this comment

wojtek-t Oct 21, 2019

Choose a reason for hiding this comment

kbhawkey Oct 18, 2019

Choose a reason for hiding this comment

wojtek-t Oct 21, 2019

Choose a reason for hiding this comment

sftim Oct 27, 2019

Choose a reason for hiding this comment

wojtek-t left a comment

Choose a reason for hiding this comment

wojtek-t Oct 21, 2019

Choose a reason for hiding this comment

wojtek-t Oct 21, 2019

Choose a reason for hiding this comment

kbhawkey commented Oct 21, 2019

kbhawkey commented Oct 23, 2019

tengqm commented Oct 28, 2019

daminisatya commented Nov 2, 2019

k8s-ci-robot commented Nov 2, 2019

daminisatya commented Nov 7, 2019

k8sio-netlify-preview-bot commented Oct 18, 2019 •

edited

Loading