kubeadm: always mount a flex volume path for the controller-manager #84468
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Checking if the path exists before creating the volume is problematic because the path will be created regardless after the initial call to "kubeadm init" and once the CM Pod is running. Then on subsequent calls to "kubeadm init" or the "control-plane" phase the manifest for the CM will be different. Always mount this path, but also consider the user provided flag override from ClusterConfiguration.
k8s-ci-robot
added
the
release-note
k8s-ci-robot
added
kind/bug
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: neolit123 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
k8s-ci-robot
added
area/kubeadm
sig/cluster-lifecycle
neolit123
changed the title
|
Thank you @neolit123! /lgtm Other reviewers, feel free to unhold. |
k8s-ci-robot
added
do-not-merge/hold
|
/retest |
k8s-ci-robot
removed
the
do-not-merge/hold
saschagrunert
added a commit
to saschagrunert/kubernetes
that referenced
this pull request
Jan 13, 2020
In kubernetes#84468 we added a host path mount for a flex volume which is needed by the controller manager. We should pre-check if the path is write-able at all because the default path might be read-only. To do this, we now do an `os.MkdirAll` and propagate the error up to to the caller. Signed-off-by: Sascha Grunert <sgrunert@suse.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Checking if the path exists before creating the volume is
problematic because the path will be created regardless
after the initial call to "kubeadm init" and once the CM Pod
is running.
Then on subsequent calls to "kubeadm init" or the "control-plane"
phase the manifest for the CM will be different.
Always mount this path, but also consider the user provided
flag override from ClusterConfiguration.
Which issue(s) this PR fixes:
Fixes kubernetes/kubeadm#1858
Special notes for your reviewer:
NONE
Does this PR introduce a user-facing change?:
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:
/assign @ereslibre @yastij
/kind bug
/priority backlog