Service Topology implementation for Kubernetes #72046
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
do-not-merge/work-in-progress
k8s-ci-robot
added
kind/api-change
m1093782566
changed the title
k8s-ci-robot
added
release-note
m1093782566
changed the title
k8s-ci-robot
added
size/M
|
/assign @thockin @johnbelamaric @wojtek-t |
k8s-ci-robot
added
the
kind/feature
m1093782566
changed the title
k8s-ci-robot
added
size/S
m1093782566
force-pushed
the
service-topology-api
branch
from
afce5bf
to
13c76b5
Compare
andrewsykim
reviewed
Nov 15, 2019
pkg/apis/core/types.go
Outdated
| // If this field is specified and all entries have no backends that match | ||
| // the topology of the client, the service has no backends for that client | ||
| // and connections should fail. | ||
| // The special value "*" may be used to mean "any node". This catch-all |
There was a problem hiding this comment.
btw, this is still unresolved, can we fix in follow-up PR?
pkg/proxy/iptables/proxier.go
Outdated
| klog.Errorf("Received a watch event for a node %s that doesn't match the current node %v", node.Name, proxier.hostname) | ||
| return | ||
| } | ||
| new := node.Labels |
There was a problem hiding this comment.
shouldn't use new, since it's a go keyword, can we rename to newLabels
pkg/proxy/iptables/proxier.go
Outdated
| return | ||
| } | ||
| new := node.Labels | ||
| old := proxier.nodeLabels |
pkg/proxy/iptables/proxier.go
Outdated
| proxier.mu.Lock() | ||
| proxier.nodeLabels = new | ||
| proxier.mu.Unlock() | ||
| if len(old) != len(new) || !reflect.DeepEqual(old, new) { |
There was a problem hiding this comment.
length is already considered from reflecy.DeepEqual?
There was a problem hiding this comment.
Yes, gonna remove length comparation.
pkg/proxy/ipvs/proxier.go
Outdated
| klog.Errorf("Received a watch event for a node %s that doesn't match the current node %v", node.Name, proxier.hostname) | ||
| return | ||
| } | ||
| new := node.Labels |
pkg/proxy/ipvs/proxier.go
Outdated
| return | ||
| } | ||
| new := node.Labels | ||
| old := proxier.nodeLabels |
pkg/proxy/ipvs/proxier.go
Outdated
| klog.Errorf("Received a watch event for a node %s that doesn't match the current node %v", node.Name, proxier.hostname) | ||
| return | ||
| } | ||
| new := node.Labels |
pkg/proxy/ipvs/proxier.go
Outdated
| return | ||
| } | ||
| new := node.Labels | ||
| old := proxier.nodeLabels |
* Implement Service Topology for ipvs and iptables proxier * Add test files * API validation
imroc
force-pushed
the
service-topology-api
branch
from
63a1a40
to
fce9324
Compare
|
/milestone v1.18 (code freeze v1.17) |
Can we request an exception to fit this into v1.17? @thockin @andrewsykim @johnbelamaric |
|
/milestone v1.17 I can lgtm by EOD PST if comments are addressed, otherwise we'll file an exception (we agreed to do this in today's SIG meeting) |
|
I see comments are addressed now, thanks @imroc /lgtm |
k8s-ci-robot
added
the
lgtm
|
/retest |
|
@imroc looks like we need to update swagger docs and protobuf |
imroc
force-pushed
the
service-topology-api
branch
from
fce9324
to
31d623b
Compare
k8s-ci-robot
removed
the
lgtm
Yes, now it's updated and pushed. |
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
/retest help wanted please. |
|
/test pull-kubernetes-e2e-gce-100-performance |
|
/retest |
|
@m1093782566: The following test failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
m1093782566
changed the title
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind api-change
/kind feature
What this PR does / why we need it:
API&Implement for feature: topology-aware service routing
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Design document of this feature is kubernetes/enhancements#640
Does this PR introduce a user-facing change?: