Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add GitHub Action to Release Chart #1066

Merged
merged 1 commit into from
Nov 17, 2020
Merged

Add GitHub Action to Release Chart #1066

merged 1 commit into from
Nov 17, 2020

Conversation

jgardner04
Copy link
Contributor

@jgardner04 jgardner04 commented Nov 17, 2020

To use this chart as a Helm 3 dependancy the chart needs to be released.

This PR adds a GitHub Action to do the following:

  • Check for changes in the chart
  • Lint the chart
  • Create a kind cluster to test if there are changes
  • Creates a release in the gh_pages branch

NOTE: A gh-pages branch will need to be created and GitHub Pages enabled for this to complete.

In my test repo I created and orphaned branch and just added an index.html. the GitHub Action will then publish the index.yaml and the release as seen on that branch.

@jgardner04 jgardner04 closed this Nov 17, 2020
@jgardner04 jgardner04 deleted the helm-chart-cicd branch November 17, 2020 00:34
@jgardner04 jgardner04 restored the helm-chart-cicd branch November 17, 2020 00:48
@jgardner04 jgardner04 reopened this Nov 17, 2020
Copy link
Collaborator

@liyinan926 liyinan926 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for contributing!

@liyinan926 liyinan926 merged commit 7c92491 into kubeflow:master Nov 17, 2020
@jgardner04 jgardner04 deleted the helm-chart-cicd branch November 17, 2020 15:52
@jgardner04
Copy link
Contributor Author

jgardner04 commented Nov 17, 2020

@liyinan926 glad I could contribute. The GH action is failing because there is not a branch called gh-pages. My recommendation is to create it using the following

git checkout master
git checkout --orphan -b gh-pages

@liyinan926
Copy link
Collaborator

@jgardner04 please create an issue for this. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants