Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updated to remove 772 error and pass the iskeyed test #861

Merged
merged 12 commits into from
Mar 13, 2021

Conversation

yysun
Copy link
Contributor

@yysun yysun commented Mar 4, 2021

No description provided.

@krausest krausest added the merging started merging started (no more updates please) label Mar 12, 2021
@krausest
Copy link
Owner

Thanks! I think it's a great step for AppRun to get rid of #772.
But I think I must mark it for using explicit event delegation #801 in the click function (which is a much minor issue than #772) .
Would you concur?

@yysun
Copy link
Contributor Author

yysun commented Mar 12, 2021 via email

@krausest krausest merged commit 9a89ba7 into krausest:master Mar 13, 2021
@krausest krausest removed the merging started merging started (no more updates please) label Mar 13, 2021
@krausest
Copy link
Owner

Thanks - results are updated. Here's the table with the latest updates:

@yysun
Copy link
Contributor Author

yysun commented Mar 14, 2021 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants