Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update cample to v3.2.1-beta.0 #1712

Merged
merged 1 commit into from
Jul 4, 2024
Merged

Conversation

antonmak1
Copy link
Contributor

I solved the problem with the click without resorting to the methods described here. The main idea is a stack of real UI, where I store state that is not in contact with the main data. That is, this can be compared to how if we entered some data into the "input", and so this data is, as it were, reflected in this idea.

I don't know, maybe this is a trivial idea, but it sounds interesting to create a separate stack for each DOM element.

@antonmak1
Copy link
Contributor Author

I don't see any more relevant ways to solve the speed problem without touching the underlying data. If you come into contact with the data, you still need to iterate through all the nodes up to the node you clicked on, and then stop. I tried this option, but the result is about the same as it was. Only a little better by 0.1.

@krausest krausest merged commit 6e40275 into krausest:master Jul 4, 2024
@krausest
Copy link
Owner

krausest commented Jul 5, 2024

The results are updated (left updated keyed results, right old results). I guess we must take a look at the big picture in the next full run.
Screenshot 2024-07-05 at 07 37 07

@antonmak1
Copy link
Contributor Author

@krausest Since the last release, I haven’t changed almost anything in other benchmarks, although the speed has dropped significantly. I don't know what the reason is. Well, this is a one-off launch, so that's ok. The main thing is that now select row shows quick results!

@antonmak1
Copy link
Contributor Author

Everything is green - finally. Then only apply graphomaniac changes like changing classList to className, textContent to nodeValue, etc.

@antonmak1
Copy link
Contributor Author

antonmak1 commented Jul 5, 2024

@krausest Anyway, thank you very much! I'm just glad that select row was fixed properly!

@antonmak1
Copy link
Contributor Author

Everything is green. How beautiful!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants