Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add sonnetjs #1693

Merged
merged 23 commits into from
Jun 15, 2024
Merged

feat: add sonnetjs #1693

merged 23 commits into from
Jun 15, 2024

Conversation

htmujahid
Copy link
Contributor

Sonnet js is an opinionated framework for writing clean and organized JavaScript code. It provides different features out of the box with vanilla javascript:

  1. SSR
  2. Routing
  3. Global Store

Here is official site of sonnetjs sonnetjs, repo

@krausest
Copy link
Owner

krausest commented Jun 4, 2024

I'm sorry it doesn't work. In the version you provided no Main.js is created in the dist directory. The build process says:

<script src="src/Main.js"> in "/index.html" can't be bundled without type="module" attribute

Can you please take a look at it?

@htmujahid
Copy link
Contributor Author

@krausest fixed this stuff

@krausest
Copy link
Owner

krausest commented Jun 7, 2024

There are still two issues. Can you please take a look at them?

  1. The page loads with 1,000 rows created. It should be empty when loading the page
  2. Create 10,000 rows causes the following error:
index-CGmytcD4.js:1 Uncaught TypeError: n is not a function
    at document.getElementById.onclick (index-CGmytcD4.js:1:5558)

The title still says vanillajs-3. It doesn't matter much, but it would be better to rename it.

@htmujahid
Copy link
Contributor Author

Sorry for issues.
I have fixed that in this build

@htmujahid
Copy link
Contributor Author

@krausest any udpate on this

@krausest krausest merged commit 4a6e460 into krausest:master Jun 15, 2024
@krausest
Copy link
Owner

Sorry, I was busy with getting chrome 126 results out.
Here's a preview of the results. Please note that vanillajs was slower than in the chrome 126 run, so it might score well in a full run!
Screenshot 2024-06-15 at 21 49 07

@krausest
Copy link
Owner

JFI: We added #772 to sonnet due to direct dom manipulation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants