Drop python 3.4 and 3.5 support

kolotaev · Apr 4, 2023 · d8d5b9f · d8d5b9f
1 parent c656ba9
commit d8d5b9f
Show file tree

Hide file tree

Showing 5 changed files with 5 additions and 6 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -9,6 +9,9 @@ All notable changes to this project will be documented in this file.
 ### Changed
 - [Storage] `MemoryStorage` `update` method now doesn't add new policy to Storage if it did not exist prior to the call.
 
+### Removed
+- Drop Python 3.4 and 3.5 support. Minimal Python version is 3.6 now.
+
 
 ## [1.5.0] - 2020-07-23
 ### Added

diff --git a/README.md b/README.md
@@ -92,7 +92,7 @@ Vakt allows you to gain:
 
 ### Install
 
-Vakt runs on Python >= 3.4.
+Vakt runs on Python >= 3.6.
 PyPy implementation is supported as well.
 
 For in-memory storage:

diff --git a/setup.py b/setup.py
@@ -24,7 +24,7 @@
         long_description=long_description,
         long_description_content_type='text/markdown',
         py_modules=['vakt'],
-        python_requires='>=3.4',
+        python_requires='>=3.6',
         install_requires=[
             'jsonpickle>=1.0',
         ],
@@ -62,8 +62,6 @@
             'Topic :: Utilities',
             'Natural Language :: English',
             'Programming Language :: Python',
-            'Programming Language :: Python :: 3.4',
-            'Programming Language :: Python :: 3.5',
             'Programming Language :: Python :: 3.6',
             'Programming Language :: Python :: 3.7',
             'Programming Language :: Python :: 3.8',

diff --git a/tests/guard/test_guard.py b/tests/guard/test_guard.py
@@ -605,7 +605,6 @@ def test_is_allowed_for_inquiry_match_rules(desc, policy, inquiry, result):
     assert result == g.is_allowed(inquiry), 'Failed for case: ' + desc
 
 
-@pytest.mark.skipif(sys.version_info <= (3, 5, 99), reason='unpredictable sorting order inquiry fields on python3.5')
 @pytest.mark.parametrize('inquiry, result, expect_message', [
     (
         Inquiry(subject='Max', action='watch', resource='TV'),

diff --git a/tests/test_audit.py b/tests/test_audit.py
@@ -113,7 +113,6 @@ def test_guard_does_not_log_messages_at_more_than_info_level(audit_log):
     assert '' == log_capture_str.getvalue().strip()
 
 
-@pytest.mark.skipif(sys.version_info <= (3, 5, 99), reason='unpredictable sorting order for policies uids on python3.5')
 @pytest.mark.parametrize('inquiry, is_allowed, expect_msg', [
     (
         Inquiry(action='get', subject='Max', resource='book'),