Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DOCS] Minor style updates #5259

Merged
merged 1 commit into from
Oct 5, 2022
Merged

[DOCS] Minor style updates #5259

merged 1 commit into from
Oct 5, 2022

Conversation

bobfuru
Copy link
Contributor

@bobfuru bobfuru commented Oct 3, 2022

Suggesting very minor style improvements. 😄

Proposed Changes

  • Compound adjectives (add hyphen)
  • s/bash/Bash

@bobfuru
Minor style updates
9ef982f 
Suggesting very minor style improvements. 😄
@netlify
Copy link

netlify bot commented Oct 3, 2022 •
edited
Loading

✅ Deploy Preview for knative ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 9ef982f
🔍 Latest deploy log https://app.netlify.com/sites/knative/deploys/633b6790a217fa0009e590ad
😎 Deploy Preview https://deploy-preview-5259--knative.netlify.app/docs/install
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@knative-prow knative-prow bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Oct 3, 2022
lance
lance reviewed Oct 4, 2022
View reviewed changes
Copy link
Member

@lance lance left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Oct 4, 2022
@bobfuru
Copy link
Contributor Author

bobfuru commented Oct 4, 2022

/assign @dprotaso

psschwei
psschwei reviewed Oct 5, 2022
View reviewed changes
Copy link
Contributor

@psschwei psschwei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@knative-prow
Copy link

knative-prow bot commented Oct 5, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bobfuru, psschwei

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 5, 2022
@knative-prow knative-prow bot merged commit 7b0718e into knative:main Oct 5, 2022
@bobfuru bobfuru deleted the patch-1 branch October 5, 2022 21:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lance lance lance left review comments

@psschwei psschwei psschwei left review comments

Assignees

@lance lance

@dprotaso dprotaso

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@bobfuru @lance @psschwei @dprotaso