Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore/bump kakarot v0 5 1 #928

Merged
merged 3 commits into from
Apr 5, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/kakarot
Submodule kakarot updated 48 files
+2 −1 .gitignore
+9 −0 deployments/starknet-sepolia/declarations.json
+7 −0 deployments/starknet-sepolia/deployments.json
+7 −2 kakarot_scripts/constants.py
+5 −1 kakarot_scripts/deploy_kakarot.py
+3 −15 src/backend/starknet.cairo
+6 −5 src/kakarot/account.cairo
+13 −2 src/kakarot/accounts/account_contract.cairo
+15 −20 src/kakarot/accounts/library.cairo
+23 −37 src/kakarot/accounts/uninitialized_account.cairo
+15 −10 src/kakarot/instructions/block_information.cairo
+16 −11 src/kakarot/instructions/environmental_information.cairo
+1 −1 src/kakarot/instructions/push_operations.cairo
+13 −9 src/kakarot/instructions/sha3.cairo
+3 −3 src/kakarot/instructions/stop_and_math_operations.cairo
+39 −28 src/kakarot/instructions/system_operations.cairo
+12 −6 src/kakarot/interfaces/interfaces.cairo
+13 −10 src/kakarot/interpreter.cairo
+72 −2 src/kakarot/kakarot.cairo
+45 −6 src/kakarot/library.cairo
+0 −2 src/kakarot/model.cairo
+5 −5 src/kakarot/precompiles/modexp.cairo
+2 −1 src/kakarot/state.cairo
+27 −3 src/utils/bytes.cairo
+8 −4 src/utils/eth_transaction.cairo
+2 −2 src/utils/modexp/modexp_utils.cairo
+93 −2 src/utils/uint256.cairo
+39 −43 src/utils/utils.cairo
+5 −9 tests/end_to_end/PlainOpcodes/test_plain_opcodes.py
+2 −1 tests/end_to_end/Solmate/test_erc20.py
+2 −2 tests/end_to_end/bytecodes.py
+20 −18 tests/end_to_end/conftest.py
+54 −5 tests/end_to_end/test_kakarot.py
+3 −2 tests/fixtures/EVM.cairo
+24 −3 tests/src/kakarot/accounts/test_contract_account.cairo
+65 −33 tests/src/kakarot/accounts/test_contract_account.py
+3 −7 tests/src/kakarot/instructions/test_block_information.py
+47 −3 tests/src/kakarot/instructions/test_environmental_information.py
+23 −1 tests/src/kakarot/test_kakarot.cairo
+84 −1 tests/src/kakarot/test_kakarot.py
+7 −2 tests/src/utils/test_bytes.cairo
+54 −5 tests/src/utils/test_bytes.py
+27 −1 tests/src/utils/test_uint256.cairo
+30 −1 tests/src/utils/test_uint256.py
+9 −24 tests/src/utils/test_utils.cairo
+12 −1 tests/src/utils/test_utils.py
+1 −7 tests/utils/helpers.cairo
+18 −0 tests/utils/syscall_handler.py
8 changes: 4 additions & 4 deletions src/eth_provider/starknet/kakarot_core.rs
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
use std::str::FromStr;

use crate::{into_via_try_wrapper, models::felt::Felt252Wrapper};
use crate::models::felt::Felt252Wrapper;
use alloy_rlp::Encodable;
use cainome::rs::abigen_legacy;
use dotenvy::dotenv;
Expand Down Expand Up @@ -56,12 +56,12 @@ lazy_static! {
/// Compute the starknet address given a eth address
#[inline]
pub fn starknet_address(address: Address) -> FieldElement {
let evm_address = into_via_try_wrapper!(address).unwrap();
let evm_address = into_via_wrapper!(address);
get_contract_address(
into_via_wrapper!(address),
evm_address,
*UNINITIALIZED_ACCOUNT_CLASS_HASH,
&[*KAKAROT_ADDRESS, evm_address],
*KAKAROT_ADDRESS,
FieldElement::ZERO,
)
}

Expand Down
1 change: 0 additions & 1 deletion src/test_utils/constants.rs
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
pub const ACCOUNT_EVM_ADDRESS: &str = "Account_evm_address";
pub const ACCOUNT_KAKAROT_ADDRESS: &str = "Account_kakarot_address";
pub const ACCOUNT_IMPLEMENTATION: &str = "Account_implementation";
pub const ACCOUNT_NONCE: &str = "Account_nonce";
pub const ACCOUNT_STORAGE: &str = "Account_storage";
Expand Down
7 changes: 2 additions & 5 deletions src/test_utils/hive/mod.rs
Original file line number Diff line number Diff line change
Expand Up @@ -13,9 +13,7 @@ use starknet_api::core::ClassHash;
use starknet_crypto::FieldElement;

use super::{
constants::{
ACCOUNT_IMPLEMENTATION, ACCOUNT_KAKAROT_ADDRESS, ACCOUNT_NONCE, KAKAROT_EVM_TO_STARKNET_ADDRESS, OWNABLE_OWNER,
},
constants::{ACCOUNT_IMPLEMENTATION, ACCOUNT_NONCE, KAKAROT_EVM_TO_STARKNET_ADDRESS, OWNABLE_OWNER},
katana::genesis::{KatanaGenesisBuilder, Loaded},
};

Expand Down Expand Up @@ -88,14 +86,13 @@ impl HiveGenesisConfig {
let mut kakarot_account_storage: Vec<(FieldElement, FieldElement)> =
kakarot_account.storage().iter().map(|(k, v)| ((*k.0.key()).into(), (*v).into())).collect();

// Add the implementation and the kakarot address to the storage.
// Add the implementation to the storage.
let implementation_key = get_storage_var_address(ACCOUNT_IMPLEMENTATION, &[])?;
kakarot_account_storage.append(&mut vec![
(implementation_key, account_contract_class_hash.0.into()),
(get_storage_var_address(ACCOUNT_NONCE, &[])?, FieldElement::ONE),
(get_storage_var_address(OWNABLE_OWNER, &[])?, kakarot_address),
]);
kakarot_account_storage.push((get_storage_var_address(ACCOUNT_KAKAROT_ADDRESS, &[])?, kakarot_address));

let key = get_storage_var_address("ERC20_allowances", &[starknet_address, kakarot_address])?;
fee_token_storage.insert(key, FieldElement::from(u128::MAX));
Expand Down
21 changes: 8 additions & 13 deletions src/test_utils/katana/genesis.rs
Original file line number Diff line number Diff line change
Expand Up @@ -3,8 +3,6 @@ use std::fs;
use std::marker::PhantomData;
use std::path::PathBuf;

use cairo_lang_starknet::casm_contract_class::CasmContractClass;
use cairo_lang_starknet::contract_class::ContractClass;
use ethers::signers::LocalWallet;
use ethers::signers::Signer;
use ethers::types::U256;
Expand All @@ -28,15 +26,15 @@ use serde_json::Value;
use serde_with::serde_as;
use starknet::core::serde::unsigned_field_element::UfeHex;
use starknet::core::types::contract::legacy::LegacyContractClass;
use starknet::core::types::contract::SierraClass;
use starknet::core::types::FieldElement;
use starknet::core::utils::{get_contract_address, get_storage_var_address, get_udc_deployed_address, UdcUniqueness};
use walkdir::WalkDir;

use crate::test_utils::constants::{
ACCOUNT_EVM_ADDRESS, ACCOUNT_IMPLEMENTATION, ACCOUNT_KAKAROT_ADDRESS, KAKAROT_ACCOUNT_CONTRACT_CLASS_HASH,
KAKAROT_BASE_FEE, KAKAROT_BLOCK_GAS_LIMIT, KAKAROT_COINBASE, KAKAROT_EVM_TO_STARKNET_ADDRESS,
KAKAROT_NATIVE_TOKEN_ADDRESS, KAKAROT_PRECOMPILES_CLASS_HASH, KAKAROT_PREV_RANDAO,
KAKAROT_UNINITIALIZED_ACCOUNT_CLASS_HASH, OWNABLE_OWNER,
ACCOUNT_EVM_ADDRESS, ACCOUNT_IMPLEMENTATION, KAKAROT_ACCOUNT_CONTRACT_CLASS_HASH, KAKAROT_BASE_FEE,
KAKAROT_BLOCK_GAS_LIMIT, KAKAROT_COINBASE, KAKAROT_EVM_TO_STARKNET_ADDRESS, KAKAROT_NATIVE_TOKEN_ADDRESS,
KAKAROT_PRECOMPILES_CLASS_HASH, KAKAROT_PREV_RANDAO, KAKAROT_UNINITIALIZED_ACCOUNT_CLASS_HASH, OWNABLE_OWNER,
};

lazy_static! {
Expand Down Expand Up @@ -219,6 +217,7 @@ impl KatanaGenesisBuilder<Loaded> {
account_contract_class_hash,
uninitialized_account_class_hash,
precompiles_class_hash,
coinbase_address,
block_gas_limit,
],
));
Expand Down Expand Up @@ -264,7 +263,6 @@ impl KatanaGenesisBuilder<Initialized> {
// Set the eoa storage
let eoa_storage = [
(storage_addr(ACCOUNT_EVM_ADDRESS)?, evm_address),
(storage_addr(ACCOUNT_KAKAROT_ADDRESS)?, kakarot_address),
(storage_addr(OWNABLE_OWNER)?, kakarot_address),
(storage_addr(ACCOUNT_IMPLEMENTATION)?, account_contract_class_hash),
]
Expand Down Expand Up @@ -359,7 +357,7 @@ impl KatanaGenesisBuilder<Initialized> {
evm_address,
uninitialized_account_class_hash,
&[kakarot_address, evm_address],
kakarot_address,
FieldElement::ZERO,
)))
}

Expand All @@ -383,11 +381,8 @@ impl KatanaGenesisBuilder<Initialized> {
}

fn compute_class_hash(class: &Value) -> Result<FieldElement> {
match serde_json::from_value::<ContractClass>(class.clone()) {
Ok(casm) => {
let casm = CasmContractClass::from_contract_class(casm, true).expect("Failed to convert class");
Ok(FieldElement::from_bytes_be(&casm.compiled_class_hash().to_be_bytes())?)
}
match serde_json::from_value::<SierraClass>(class.clone()) {
Ok(sierra) => Ok(sierra.class_hash()?),
Err(_) => {
let casm: LegacyContractClass =
serde_json::from_value(class.clone()).expect("Failed to parse class code v0");
Expand Down
Loading