Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change ref from joblib.load to joblib.dump in the docstring #45

Merged
merged 3 commits into from
Jul 10, 2019
Merged

Change ref from joblib.load to joblib.dump in the docstring #45

merged 3 commits into from
Jul 10, 2019

Conversation

deepyaman
Copy link
Member

@deepyaman deepyaman commented Jul 3, 2019

Notice

  • I acknowledge and agree that, by checking this box and clicking "Submit Pull Request":

  • I submit this contribution under the Apache 2.0 license and represent that I am entitled to do so on behalf of myself, my employer, or relevant third parties, as applicable.

  • I certify that (a) this contribution is my original creation and / or (b) to the extent it is not my original creation, I am authorised to submit this contribution on behalf of the original creator(s) or their licensees.

  • I certify that the use of this contribution as authorised by the Apache 2.0 license does not violate the intellectual property rights of anyone else.

Motivation and Context

Why was this PR created?

How has this been tested?

What testing strategies have you used?

Checklist

  • Read the contributing guidelines
  • Opened this PR as a 'Draft Pull Request' if it is work-in-progress
  • Updated the documentation to reflect the code changes
  • Added new entries to the RELEASE.md file
  • Added tests to cover my changes
  • Assigned myself to the PR

@ghost ghost assigned deepyaman Jul 4, 2019
Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nicely spotted, thank you! Before merging could you please tick the checkbox if you've read our contributing guide, and add your name to supporting contributors under the next release section in RELEASE.md? :)

@deepyaman
Copy link
Member Author

Nicely spotted, thank you! Before merging could you please tick the checkbox if you've read our contributing guide, and add your name to supporting contributors under the next release section in RELEASE.md? :)

Done!

@ghost ghost requested a review from DmitriiDeriabinQB July 8, 2019 15:12
@921kiyo 921kiyo self-requested a review July 9, 2019 15:48
Copy link
Contributor

@921kiyo 921kiyo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for spotting this!

@idanov idanov changed the title Change ref from joblib.load to joblib.dump Change ref from joblib.load to joblib.dump in the docstring Jul 10, 2019
@idanov idanov merged commit a3824c6 into kedro-org:develop Jul 10, 2019
kopytjuk pushed a commit to kopytjuk/kedro that referenced this pull request Jul 10, 2019
kopytjuk pushed a commit to kopytjuk/kedro that referenced this pull request Jul 15, 2019
@deepyaman deepyaman deleted the patch-1 branch August 6, 2019 19:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants