Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Prefect 2.0 guide for simple deployment with agent on localhost #2748

Merged
merged 5 commits into from
Jul 3, 2023
Merged

Add Prefect 2.0 guide for simple deployment with agent on localhost #2748

merged 5 commits into from
Jul 3, 2023

Conversation

jmalovera10
Copy link
Contributor

Add a step by step deployment guide for Kedro with Prefect 2.0. The guide includes a basic example of leveraging local resources with an agent that pulls from a work pool

NOTE: Kedro datasets are moving from kedro.extras.datasets to a separate kedro-datasets package in
kedro-plugins repository. Any changes to the dataset implementations
should be done by opening a pull request in that repository.

Description

Development notes

Continuation of #2725. Add a deployment guide for Prefect 2.0 regarding #2431

Checklist

  • Read the contributing guidelines
  • Opened this PR as a 'Draft Pull Request' if it is work-in-progress
  • Updated the documentation to reflect the code changes
  • Added a description of this change in the RELEASE.md file
  • Added tests to cover my changes

@jmalovera10
Add Prefect 2.0 guide for simple deployment with agent
f99cb39 
Add a step by step deployment guide for Kedro with Prefect 2.0. The guide includes a basic example of leveraging local resources with an agent that pulls from a work pool

Signed-off-by: Juan Lovera <8958924+jmalovera10@users.noreply.github.com>
@jmalovera10
Copy link
Contributor Author

jmalovera10 commented Jun 30, 2023 •
edited
Loading

@astrojuanlu @stichbury @yetudada sorry for the inconveniences with the other PR. I added the last changes from #2725 and added the latest suggestions from @stichbury. Let me know if there are other changes that could be done to further improve the documentation 😃

@jmalovera10 jmalovera10 changed the title Add Prefect 2.0 guide for simple deployment with agent Add Prefect 2.0 guide for simple deployment with agent on localhost Jun 30, 2023
stichbury
stichbury approved these changes Jun 30, 2023
View reviewed changes
Copy link
Contributor

@stichbury stichbury left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is brilliant -- thank you so much for persevering with these changes and contributing to the docs. We really appreciate it.

Just a couple of minor suggestions to drop in but otherwise I'm happy to approve. I've not run end-to-end tests but all is good from my perspective in terms of clear explanations and great writing.

@jmalovera10
Include introduction section suggestions
9f8d938 
Clarify on the conditions in which this guide was executed and better orient the developer to earlier versions for documentation on Prefect 1.0. Fix redaction on second paragraph.

Signed-off-by: Juan Lovera <8958924+jmalovera10@users.noreply.github.com>
@jmalovera10
Merge branch 'docs/prefect_2_basic_deployment' of https://github.com/…
5d7e62b 
…jmalovera10/kedro into docs/prefect_2_basic_deployment

Signed-off-by: Juan Lovera <8958924+jmalovera10@users.noreply.github.com>

Signed-off-by: Juan Lovera <8958924+jmalovera10@users.noreply.github.com>
@jmalovera10
Copy link
Contributor Author

@stichbury I just included your suggestions. Thank you very much for your feedback 😃

astrojuanlu
astrojuanlu approved these changes Jul 3, 2023
View reviewed changes
Copy link
Member

@astrojuanlu astrojuanlu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is fantastic, thanks a lot @jmalovera10 for your contribution! Let's get this merged

@astrojuanlu astrojuanlu merged commit 574cff1 into kedro-org:main Jul 3, 2023
3 checks passed
@astrojuanlu astrojuanlu mentioned this pull request Jul 3, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@astrojuanlu astrojuanlu astrojuanlu approved these changes

@stichbury stichbury stichbury approved these changes

@yetudada yetudada Awaiting requested review from yetudada yetudada is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jmalovera10 @astrojuanlu @stichbury