-
Notifications
You must be signed in to change notification settings - Fork 893
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update pipeline_registry.md #2641
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot for this PR @jacobweiss2305!
Could you also signoff the commit as the DCO check advises? You will need to amend your commit and force push.
@astrojuanlu , Am I reading this correctly? All I need to do is add, Signed-off-by: Author Name authoremail@example.com, in the commit message? Is there a way to edit the commit message? I have never done that before. |
Yes!
Indeed, you can do |
Adding important import statements Signed-off-by: jacob weiss <jacob.weiss@data-axle.com>
@astrojuanlu okay I followed your instructions and fixed changes. |
Thanks @jacobweiss2305! Now, it looks like there are some linting failures, some of which seem unrelated to this PR. Please update your PR, either by rebasing or merging the current |
I have no idea why the linting is failing on files that weren't touched. But it's also failing on |
Co-authored-by: Juan Luis Cano Rodríguez <hello@juanlu.space>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've completed this PR to get it merged. Approving.
Unrelated RTD failure:
|
@jacobweiss2305 we'll take it from here, thanks for your contribution! |
Signed-off-by: Jo Stichbury <jo_stichbury@mckinsey.com>
Signed-off-by: Jo Stichbury <jo_stichbury@mckinsey.com>
* Update pipeline_registry.md Adding important import statements Signed-off-by: jacob weiss <jacob.weiss@data-axle.com> * Update docs/source/nodes_and_pipelines/pipeline_registry.md Co-authored-by: Juan Luis Cano Rodríguez <hello@juanlu.space> * linted Signed-off-by: Jo Stichbury <jo_stichbury@mckinsey.com> * fix broken link Signed-off-by: Jo Stichbury <jo_stichbury@mckinsey.com> * Actually fixing broken link Signed-off-by: Jo Stichbury <jo_stichbury@mckinsey.com> --------- Signed-off-by: jacob weiss <jacob.weiss@data-axle.com> Signed-off-by: Jo Stichbury <jo_stichbury@mckinsey.com> Co-authored-by: Nok Lam Chan <nok.lam.chan@quantumblack.com> Co-authored-by: Jo Stichbury <jo_stichbury@mckinsey.com> Co-authored-by: Juan Luis Cano Rodríguez <hello@juanlu.space> Signed-off-by: Juan Lovera <8958924+jmalovera10@users.noreply.github.com>
Adding important import statements
Description
Development notes
Checklist
RELEASE.md
file