Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update pipeline_registry.md #2641

Merged
merged 9 commits into from
Jun 19, 2023
Merged

Conversation

jacobweiss2305
Copy link
Contributor

Adding important import statements

NOTE: Kedro datasets are moving from kedro.extras.datasets to a separate kedro-datasets package in
kedro-plugins repository. Any changes to the dataset implementations
should be done by opening a pull request in that repository.

Description

Development notes

Checklist

  • Read the contributing guidelines
  • Opened this PR as a 'Draft Pull Request' if it is work-in-progress
  • Updated the documentation to reflect the code changes
  • Added a description of this change in the RELEASE.md file
  • Added tests to cover my changes

Copy link
Member

@astrojuanlu astrojuanlu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for this PR @jacobweiss2305!

Could you also signoff the commit as the DCO check advises? You will need to amend your commit and force push.

docs/source/nodes_and_pipelines/pipeline_registry.md Outdated Show resolved Hide resolved
@jacobweiss2305
Copy link
Contributor Author

@astrojuanlu , Am I reading this correctly?

All I need to do is add, Signed-off-by: Author Name authoremail@example.com, in the commit message?

Is there a way to edit the commit message? I have never done that before.

@astrojuanlu
Copy link
Member

All I need to do is add, Signed-off-by: Author Name authoremail@example.com, in the commit message?

Yes!

Is there a way to edit the commit message? I have never done that before.

Indeed, you can do git commit --amend --signoff --no-edit and it will edit your last commit. Then you'd need to do git push --force to overwrite it. For more instructions, have a look at https://github.com/kedro-org/kedro/pull/2641/checks?check_run_id=14010473825

Adding important import statements

Signed-off-by: jacob weiss <jacob.weiss@data-axle.com>
@jacobweiss2305
Copy link
Contributor Author

@astrojuanlu okay I followed your instructions and fixed changes.

@astrojuanlu
Copy link
Member

Thanks @jacobweiss2305! Now, it looks like there are some linting failures, some of which seem unrelated to this PR. Please update your PR, either by rebasing or merging the current main, and let's see if the CI is happy. If you do manual commits on the command line, remember to add the --signoff flag.

@astrojuanlu
Copy link
Member

I have no idea why the linting is failing on files that weren't touched. But it's also failing on pipeline_registry.md. Could you please run make lint locally and commit the results? Also, there's an outstanding review comment from me.

stichbury and others added 3 commits June 19, 2023 10:24
Co-authored-by: Juan Luis Cano Rodríguez <hello@juanlu.space>
Signed-off-by: Jo Stichbury <jo_stichbury@mckinsey.com>
Copy link
Contributor

@stichbury stichbury left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've completed this PR to get it merged. Approving.

@astrojuanlu
Copy link
Member

Unrelated RTD failure:

sphinx.errors.SphinxWarning: /home/docs/checkouts/readthedocs.org/user_builds/kedro/checkouts/2641/docs/source/deployment/aws_step_functions.md:203:broken link: https://docs.aws.amazon.com/lambda/latest/dg/images-create.html#images-create-from-alt (Anchor 'images-create-from-alt' not found)

@astrojuanlu
Copy link
Member

@jacobweiss2305 we'll take it from here, thanks for your contribution!

Signed-off-by: Jo Stichbury <jo_stichbury@mckinsey.com>
Signed-off-by: Jo Stichbury <jo_stichbury@mckinsey.com>
@stichbury stichbury merged commit c48a846 into kedro-org:main Jun 19, 2023
3 checks passed
jmalovera10 pushed a commit to jmalovera10/kedro that referenced this pull request Jun 30, 2023
* Update pipeline_registry.md

Adding important import statements

Signed-off-by: jacob weiss <jacob.weiss@data-axle.com>

* Update docs/source/nodes_and_pipelines/pipeline_registry.md

Co-authored-by: Juan Luis Cano Rodríguez <hello@juanlu.space>

* linted

Signed-off-by: Jo Stichbury <jo_stichbury@mckinsey.com>

* fix broken link

Signed-off-by: Jo Stichbury <jo_stichbury@mckinsey.com>

* Actually fixing broken link

Signed-off-by: Jo Stichbury <jo_stichbury@mckinsey.com>

---------

Signed-off-by: jacob weiss <jacob.weiss@data-axle.com>
Signed-off-by: Jo Stichbury <jo_stichbury@mckinsey.com>
Co-authored-by: Nok Lam Chan <nok.lam.chan@quantumblack.com>
Co-authored-by: Jo Stichbury <jo_stichbury@mckinsey.com>
Co-authored-by: Juan Luis Cano Rodríguez <hello@juanlu.space>
Signed-off-by: Juan Lovera <8958924+jmalovera10@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants