Restore accidentally-deleted PR naming conventions #1689
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Deepyaman Datta <deepyaman.datta@utexas.edu>
Signed-off-by: Deepyaman Datta <deepyaman.datta@utexas.edu>
deepyaman
commented
Jul 5, 2022
| show_locals=True, suppress=[click, str(Path(sys.executable).parent)] | ||
| ) | ||
| rich_pretty_install() | ||
| rich.pretty.install() |
There was a problem hiding this comment.
@AntonyMilneQB I piggy-backed a trivial change that I wanted to suggest upon reviewing some of the new rich code. I think it's better to just use the original module path, rather than from ... import ... as ... and basically end up with the same thing, with underscores replacing dots.
There was a problem hiding this comment.
Very good suggestion, thank you!
antonymilne
approved these changes
Jul 5, 2022
| show_locals=True, suppress=[click, str(Path(sys.executable).parent)] | ||
| ) | ||
| rich_pretty_install() | ||
| rich.pretty.install() |
There was a problem hiding this comment.
Very good suggestion, thank you!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Deepyaman Datta deepyaman.datta@utexas.edu
Description
5ca2fca accidentally dropped the PR naming conventions introduced in a47ca06 (or at least I don't see any justification in https://github.com/quantumblacklabs/private-kedro/pull/1169, having trawled through the comments therein).
Maybe it's just me, but I really do appreciate more standardized commit messages when contributing to and looking through change logs of other open source projects, and I think there is no downside to enforcing some convention. I would also be happy with a stricter convention (e.g. Conventional Commit), but Kedro hasn't followed anything as such so far, and that's OK.
Development notes
Checklist
RELEASE.mdfile