Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Documentation improvements #1656

Merged
merged 5 commits into from
Jul 4, 2022
Merged

Documentation improvements #1656

merged 5 commits into from
Jul 4, 2022

Conversation

merelcht
Copy link
Member

@merelcht merelcht commented Jun 30, 2022 •
edited by gitpod-io bot
Loading

Signed-off-by: Merel Theisen merel.theisen@quantumblack.com

Description

This PR is a follow up on all the suggestions left on #1629 after it was merged.

Checklist

  • Read the contributing guidelines
  • Opened this PR as a 'Draft Pull Request' if it is work-in-progress
  • Updated the documentation to reflect the code changes
  • Added a description of this change in the RELEASE.md file
  • Added tests to cover my changes

@merelcht
Suggested doc improvements from review
a82df88 
Signed-off-by: Merel Theisen <merel.theisen@quantumblack.com>
@merelcht merelcht marked this pull request as ready for review June 30, 2022 11:26
@merelcht merelcht requested a review from yetudada as a code owner June 30, 2022 11:26
@merelcht merelcht mentioned this pull request Jun 30, 2022
Merged
5 tasks
@merelcht merelcht self-assigned this Jul 4, 2022
antonymilne
antonymilne approved these changes Jul 4, 2022
View reviewed changes
Copy link
Contributor

@antonymilne antonymilne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work, thank you!

docs/source/data/data_catalog.md Outdated Show resolved Hide resolved
docs/source/deployment/argo.md Outdated Show resolved Hide resolved
docs/source/deployment/aws_step_functions.md Outdated Show resolved Hide resolved
docs/source/development/debugging.md Show resolved Hide resolved
merelcht and others added 2 commits July 4, 2022 12:25
@merelcht @antonymilne
Apply suggestions from code review
656fd21 
Co-authored-by: Antony Milne <49395058+AntonyMilneQB@users.noreply.github.com>
@merelcht @antonymilne
Update docs/source/data/data_catalog.md
886a03a 
Co-authored-by: Antony Milne <49395058+AntonyMilneQB@users.noreply.github.com>
SajidAlamQB
SajidAlamQB approved these changes Jul 4, 2022
View reviewed changes
Copy link
Contributor

@SajidAlamQB SajidAlamQB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome!

@merelcht merelcht merged commit 639cc2e into main Jul 4, 2022
@merelcht merelcht deleted the docs/improvements-follow-up branch July 4, 2022 14:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@antonymilne antonymilne antonymilne approved these changes

@SajidAlamQB SajidAlamQB SajidAlamQB approved these changes

@yetudada yetudada Awaiting requested review from yetudada yetudada is a code owner

@AhdraMeraliQB AhdraMeraliQB Awaiting requested review from AhdraMeraliQB

Assignees

@merelcht merelcht

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@merelcht @antonymilne @SajidAlamQB