Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump mypy ver to the latest, M1-compatible release #1605

Merged
merged 9 commits into from
Jun 14, 2022
Merged

Bump mypy ver to the latest, M1-compatible release #1605

merged 9 commits into from
Jun 14, 2022

Conversation

deepyaman
Copy link
Member

@deepyaman deepyaman commented Jun 9, 2022 •
edited
Loading

Signed-off-by: Deepyaman Datta deepyaman.datta@utexas.edu

Description

Development notes

Checklist

  • Read the contributing guidelines
  • Opened this PR as a 'Draft Pull Request' if it is work-in-progress
  • Updated the documentation to reflect the code changes
  • Added a description of this change in the RELEASE.md file
  • Added tests to cover my changes

@deepyaman
Bump mypy ver to the latest, M1-compatible release
b5a8f0a 
Signed-off-by: Deepyaman Datta <deepyaman.datta@utexas.edu>
@deepyaman
Bump pre-commit version to that required by mypy
213c096 
Signed-off-by: Deepyaman Datta <deepyaman.datta@utexas.edu>
@deepyaman
Use mypy --install-types to add more library stubs
67705b2 
Signed-off-by: Deepyaman Datta <deepyaman.datta@utexas.edu>
deepyaman
deepyaman commented Jun 9, 2022
View reviewed changes
test_requirements.txt Outdated Show resolved Hide resolved
@deepyaman
Restore accidentally-removed tensorflow dependency
d0915c0 
Signed-off-by: Deepyaman Datta <deepyaman.datta@utexas.edu>
@deepyaman
Move additional dependencies to pre-commmit config
e2a7a82 
Signed-off-by: Deepyaman Datta <deepyaman.datta@utexas.edu>
@deepyaman
Solve the strict optional typing error with assert
753f26f 
Signed-off-by: Deepyaman Datta <deepyaman.datta@utexas.edu>
@deepyaman deepyaman marked this pull request as ready for review June 10, 2022 00:22
@deepyaman deepyaman requested a review from idanov as a code owner June 10, 2022 00:22
merelcht
merelcht approved these changes Jun 13, 2022
View reviewed changes
Copy link
Member

@merelcht merelcht left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 👍

@merelcht merelcht merged commit 5a72723 into kedro-org:main Jun 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@antonymilne antonymilne antonymilne approved these changes

@merelcht merelcht merelcht approved these changes

@idanov idanov Awaiting requested review from idanov

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@deepyaman @antonymilne @merelcht