Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 pkg/tunneler: remove non-error verbose log #2766

Conversation

jmprusi
Copy link
Member

@jmprusi jmprusi commented Feb 8, 2023

Summary

When the KCPSyncerTunnel feature is enabled, the podsubresourceproxy_handler outputs an error log line that's not an error and is too verbose:

E0208 19:18:24.074484 1740192 podsubresourceproxy_handler.go:113] "no cluster found in the context"
E0208 19:18:27.150451 1740192 podsubresourceproxy_handler.go:113] "no cluster found in the context"
E0208 19:18:28.073389 1740192 podsubresourceproxy_handler.go:113] "no cluster found in the context"
E0208 19:18:28.746808 1740192 podsubresourceproxy_handler.go:113] "no cluster found in the context"
E0208 19:18:30.579766 1740192 podsubresourceproxy_handler.go:113] "no cluster found in the context"
E0208 19:18:31.075186 1740192 podsubresourceproxy_handler.go:113] "no cluster found in the context"
E0208 19:18:32.343049 1740192 podsubresourceproxy_handler.go:113] "no cluster found in the context"
E0208 19:18:34.562156 1740192 podsubresourceproxy_handler.go:113] "no cluster found in the context"
E0208 19:18:36.427920 1740192 podsubresourceproxy_handler.go:113] "no cluster found in the context"
E0208 19:18:37.075720 1740192 podsubresourceproxy_handler.go:113] "no cluster found in the context"

This PR removes that log line.

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Feb 8, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Feb 8, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: davidfestal

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 8, 2023
@jmprusi
Copy link
Member Author

jmprusi commented Feb 8, 2023

/retest

1 similar comment
@ncdc
Copy link
Member

ncdc commented Feb 8, 2023

/retest

@openshift-merge-robot openshift-merge-robot merged commit 2244d9a into kcp-dev:main Feb 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants