🐛Syncer namespace cleanup refactor #2374
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci
bot
added
the
do-not-merge/work-in-progress
|
Skipping CI for Draft Pull Request. |
|
/test all |
jmprusi
force-pushed
the
jmprusi/syncer-namespace-fix-missing-index
branch
from
169c9c8
to
0fbb67b
Compare
openshift-merge-robot
added
the
needs-rebase
jmprusi
force-pushed
the
jmprusi/syncer-namespace-fix-missing-index
branch
from
56ae1aa
to
9dfa2cc
Compare
openshift-merge-robot
removed
the
needs-rebase
|
/test e2e-sharded |
jmprusi
force-pushed
the
jmprusi/syncer-namespace-fix-missing-index
branch
from
29ca135
to
0c557cd
Compare
jmprusi
force-pushed
the
jmprusi/syncer-namespace-fix-missing-index
branch
3 times, most recently
from
8e292c3
to
7c250c6
Compare
jmprusi
changed the title
openshift-ci
bot
removed
the
do-not-merge/work-in-progress
jmprusi
force-pushed
the
jmprusi/syncer-namespace-fix-missing-index
branch
4 times, most recently
from
f1bb8d8
to
f4d8dcc
Compare
| @@ -466,3 +463,11 @@ func getAllGVRs(synctarget *workloadv1alpha1.SyncTarget) map[schema.GroupVersion | |||
|
|
|||
| return gvrs | |||
| } | |||
|
|
|||
| func IndexByNamespace(obj interface{}) ([]string, error) { | |||
There was a problem hiding this comment.
Can we please use the upstream index.
ncdc
added
the
area/transparent-multi-cluster
jmprusi
force-pushed
the
jmprusi/syncer-namespace-fix-missing-index
branch
2 times, most recently
from
186ecc4
to
c368f96
Compare
jmprusi
force-pushed
the
jmprusi/syncer-namespace-fix-missing-index
branch
2 times, most recently
from
eb92474
to
5a3d31c
Compare
jmprusi
changed the title
|
/test e2e-sharded |
jmprusi
force-pushed
the
jmprusi/syncer-namespace-fix-missing-index
branch
from
5a3d31c
to
b415bc4
Compare
|
/test e2e-sharded |
1 similar comment
|
/test e2e-sharded |
davidfestal
approved these changes
Nov 17, 2022
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: davidfestal The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Refactor how the syncer handles the deletion of downstream namespaces.
--downstream-namespace-clean-delayflag and set it to 2s for tests.