-
Notifications
You must be signed in to change notification settings - Fork 376
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
📖 Updated README.md links #2255
Conversation
Signed-off-by: Eran Cohen <eranco@redhat.com>
Hi @eranco74. Thanks for your PR. I'm waiting for a kcp-dev member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Ah indeed missed 😅. Now that our documentation site is up, I was thinking about putting links to site pages instead of markdowns. WDYT @hardys? In case you haven't checked the site yet, please do https://docs.kcp.io/kcp/main |
My only concern with that is we seem to only publish docs for Leaving the links to the markdown seems like the simplest solution unless there is a plan to publish per-release docs on the site? |
@eranco74 the PR verifier is failing on this check - I think you'll have to make the PR description a bit more verbose |
I have added the versioned docs mechanism in GitHub Actions. Since this is our first ever docs site so we have only the |
/lgtm |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: stevekuznetsov The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Summary
The links to
additional documentation
(Concepts, Workspaces, etc) are broken, this PR fixes the links path