This repository has been archived by the owner on May 12, 2021. It is now read-only.
blk-dev: hotplug read only if applicable #3115
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/test |
Codecov Report
@@ Coverage Diff @@
## master #3115 +/- ##
==========================================
+ Coverage 50.28% 50.30% +0.02%
==========================================
Files 120 120
Lines 15994 16003 +9
==========================================
+ Hits 8043 8051 +8
- Misses 6859 6861 +2
+ Partials 1092 1091 -1 |
|
Marking as dnm due to vendor change. @egernst - I'm slightly surprised this is being raised on 1.x - is this correct? |
|
It is correct. I'll be back porting to stable and forward to 2.0 as well. I think we'll want to update our vendoring to be consistent between these. |
Let's keep aligned with Kata 2.0, and utilize the kata-container organizations' govmm. Fixes: kata-containers#3000 Signed-off-by: Eric Ernst <eric.g.ernst@gmail.com>
We are adding access-mode for hotplugged blk devices. Let's revendor govmm so we can apply this for QEMU. Signed-off-by: Eric Ernst <eric_ernst@apple.com>
egernst
force-pushed
the
storage-cleanup
branch
from
8fef762
to
1953f62
Compare
|
/test |
egernst
force-pushed
the
storage-cleanup
branch
from
1953f62
to
2409000
Compare
|
/test |
|
Minor update to fix pmem test failures. |
egernst
force-pushed
the
storage-cleanup
branch
from
2409000
to
cdda12a
Compare
|
/test |
egernst
force-pushed
the
storage-cleanup
branch
from
cdda12a
to
7af83d9
Compare
|
/test |
Update some headers, very minor refactoring Signed-off-by: Eric Ernst <eric.g.ernst@gmail.com>
If a block based volume is read only, let's make sure we add as a RO device Fixes: kata-containers#3114 Signed-off-by: Eric Ernst <eric.g.ernst@gmail.com>
egernst
force-pushed
the
storage-cleanup
branch
from
7af83d9
to
b2956f3
Compare
|
/test |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a volume is backed by a block device, let's make sure we take into account whether it should be hot plugged RO or not.
While updating this, I made some minor non-functional changes to correct comments, make storage handling a bit more clear.