Remove annotation config json key #2028
Conversation
|
/test |
|
depends-on: #2022 Waiting for it's merging. |
WeiZhang555
force-pushed
the
remove-annotation-ConfigJSONKey
branch
from
77f1b41
to
42e603f
Compare
Codecov Report
@@ Coverage Diff @@
## master #2028 +/- ##
==========================================
- Coverage 51.67% 51.61% -0.06%
==========================================
Files 107 108 +1
Lines 14615 14617 +2
==========================================
- Hits 7552 7545 -7
- Misses 6152 6168 +16
+ Partials 911 904 -7 |
Codecov Report
@@ Coverage Diff @@
## master #2028 +/- ##
==========================================
- Coverage 51.93% 51.87% -0.07%
==========================================
Files 107 108 +1
Lines 14465 14461 -4
==========================================
- Hits 7513 7502 -11
- Misses 6060 6072 +12
+ Partials 892 887 -5 |
WeiZhang555
force-pushed
the
remove-annotation-ConfigJSONKey
branch
2 times, most recently
from
29d3c70
to
0fabefd
Compare
|
/test |
| @@ -47,9 +47,6 @@ const ( | |||
| // AssetHashType is the hash type used for assets verification | |||
| AssetHashType = vcAnnotationsPrefix + "AssetHashType" | |||
|
|
|||
| // ConfigJSONKey is the annotation key to fetch the OCI configuration. | |||
| ConfigJSONKey = vcAnnotationsPrefix + "pkg.oci.config" | |||
There was a problem hiding this comment.
Since this is an API change, we need to think about how we're going to manage its removal - if this PR is merged and we make a new release, some users may be surprised the feature has disappeared 😄
Related: #1113 (comment)
@egernst, @gnawux - any thoughts on this? Raise this issue in the AC meeting and announce the plan on the mailing list?
There was a problem hiding this comment.
@jodh-intel I don't think it's an API change. This annotation is used for storing OCI spec in kata-runtime itself's configuration. It's not exposed to user and user won't have any way to use it, so this is an internal change and it's definitely safe to remove 😄
There was a problem hiding this comment.
Sorry @WeiZhang555 ! You are of course correct - the lower-case pkg.oci prefix should have been the clue to me 😄
WeiZhang555
force-pushed
the
remove-annotation-ConfigJSONKey
branch
2 times, most recently
from
0332362
to
186f48e
Compare
WeiZhang555
changed the title
|
/test |
Fixes: kata-containers#2023 We can get OCI spec config from bundle instead of annotations, so this field isn't necessary. Signed-off-by: Wei Zhang <weizhang555.zw@gmail.com>
WeiZhang555
force-pushed
the
remove-annotation-ConfigJSONKey
branch
from
186f48e
to
2ed94cb
Compare
|
LGTM |
This is a WIP PR trying to remove ConfigJSONKey annotation.
Currently we have several places saving the OCI spec in configurations which bing a lot of redundancy and confusion, the plan is removing them all and only keep "bundle/config.json" from upper level components.
Fixes: #2023
We can get OCI spec config from bundle instead of annotations, so this
field isn't necessary.
Signed-off-by: Wei Zhang weizhang555.zw@gmail.com