Trait revision part 3: merge Component and Layout traits; put layout storage in widget_core!() #314
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Quality of life improvements:
#[widget_core] core: CoreData
field withcore: widget_core!()
Grid
)Details:
widget_core!()
, which is generated where necessary; these fields may have explicit names where external access is desiredLayout
identical toComponent
trait, then replace the latter with the formerkas::layout::Layout
toVisitor
; this should perhaps be removed but is currently used for implementation oflayout
macro syntaxSingle-item macro layout currently uses
component: self.foo
syntax: ideally this would just beself.foo
, but there is a small issue here. (Drawing a widget assigns that widget's id toDrawMgr
, but components don't have an id.)