Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(web-server): include html files as <link rel="import"> #882

Merged
merged 1 commit into from
Jan 30, 2014
Merged

feat(web-server): include html files as <link rel="import"> #882

merged 1 commit into from
Jan 30, 2014

Conversation

morethanreal
Copy link

Addresses #828.

@nfroidure
Copy link

👍

@hppycoder
Copy link

The issue I see with this is that the HTML5 spec isn't close to finalized, so we might be jumping the gun. That being said even if it was finalized this wouldn't solve the spec as it allows HTML, JS, and CSS. Yours would only take into consideration the HTML side, not the JS side of things. I would suggest adding in JS and test with that as well so it covers what's part of the current spec (as written today).

Spec:
http://w3c.github.io/webcomponents/spec/imports/

HTML5Rocks article:
http://www.html5rocks.com/en/tutorials/webcomponents/imports/

@morethanreal
Copy link
Author

This patch intends to address the problem of including HTML in karma tests which is impossible today without using html2js. There are already standard mechanisms to include CSS and JS that karma can continue using.

vojtajina added a commit that referenced this pull request Jan 30, 2014
feat(web-server): include html files as <link rel="import">
@vojtajina vojtajina merged commit 203a396 into karma-runner:master Jan 30, 2014
@vojtajina
Copy link
Contributor

@morethanreal Thanks!

If html2js or ng-html2js preprocessor is used, the served path is changed to *.html.js, so this change does not affect that case.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants